Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29979 )
Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29979
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I79c51b78d1b055361f9ef5434361847353791d0d
Gerrit-Change-Number: 29979
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 04 Nov 2022 04:16:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29975 )
Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29975
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I84fd99442d0cc400fa562fa33623c142649230e2
Gerrit-Change-Number: 29975
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 04 Nov 2022 04:14:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29996 )
Change subject: Improve MS logging
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
File src/gprs_ms.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/29996/comment/ab606b73_5f14b315
PS2, Line 1030: if (tlli != GSM_RESERVED_TMSI)
For the sake of explicitness, I would print TLLI unconditionally.
https://gerrit.osmocom.org/c/osmo-pcu/+/29996/comment/1f01e277_fc964f3b
PS2, Line 1032: MSCLS
Everything is about the MS here, so 'MS' in 'MSCLS' is redundant IMO.
https://gerrit.osmocom.org/c/osmo-pcu/+/29996/comment/f432523b_106557b3
PS2, Line 1032: PRIu8 "-%" PRIu8
I suggest prefixing the values with 'G' and 'E', respectively. This way it's clear which is GPRS class and which is EGPRS class: CLS-G%02u-E%02u.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29996
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If9b325764c8fd540d60b6419f32223fd7f5a5898
Gerrit-Change-Number: 29996
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Nov 2022 04:08:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29996 )
Change subject: Improve MS logging
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcu/+/29996/comment/1a1f6e1d_7838fc0d
PS1, Line 9: towaht
> to what
Done
File src/gprs_ms.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/29996/comment/4736e27b_4cc6847f
PS1, Line 1030: if (tlli != GSM_RESERVED_TMSI)
> meaning: the indentation is wrong, should be two tabs, not three in the line below.
Done
https://gerrit.osmocom.org/c/osmo-pcu/+/29996/comment/be3058fb_76002e5c
PS1, Line 1040: return buf;
> dead code, did you mean to delete everything below this return?
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29996
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If9b325764c8fd540d60b6419f32223fd7f5a5898
Gerrit-Change-Number: 29996
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Nov 2022 04:00:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment