November 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: paging: Optimize retrieving number of request per paging group

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30370 ) Change subject: paging: Optimize retrieving number of request per paging group ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6994127827d120a0b4dd3de51e1ddde39f2fe531 Gerrit-Change-Number: 30370 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 12:09:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: paging: Fix wrong count of reqs_before if queue only contains retrans...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30362 ) Change subject: paging: Fix wrong count of reqs_before if queue only contains retransmissions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib2e810b0bcc51eac117713584310272462c58867 Gerrit-Change-Number: 30362 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 12:06:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: paging: Split paging queue into 2 queues: initial and retrans

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30363 ) Change subject: paging: Split paging queue into 2 queues: initial and retrans ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/f92f427a_55b45a92 PS1, Line 263: bts_pag_st->initial_req_list_len--; You already adjust the *_list_len accordingly in paging_remove_request(). I'd suggest to do that in paging_req_timeout_trans() as well if req->attempts == 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747 Gerrit-Change-Number: 30363 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 11:57:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: mobile: timeout_rr_meas(): fix sprintf() formatting

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30378 ) Change subject: mobile: timeout_rr_meas(): fix sprintf() formatting ...................................................................... mobile: timeout_rr_meas(): fix sprintf() formatting Change-Id: Ia8a101005d027fb5d0ddc2566f92ab2060f21c36 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/78/30378/1 diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index b42ab3a..8e3b61b 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -655,9 +655,9 @@ gsm_print_mnc(cs->sel_mnc), cs->sel_lac, cs->sel_id); if (rr->state == GSM48_RR_ST_DEDICATED) { sprintf(text + strlen(text), " TA=%d pwr=%d", - rr->cd_now.ind_ta - set->alter_delay, - (set->alter_tx_power) ? set->alter_tx_power_value - : rr->cd_now.ind_tx_power); + rr->cd_now.ind_ta - set->alter_delay, + (set->alter_tx_power) ? set->alter_tx_power_value + : rr->cd_now.ind_tx_power); if (rsl_dec_chan_nr(rr->cd_now.chan_nr, &ch_type, &ch_subch, &ch_ts) == 0) { sprintf(text + strlen(text), " TS=%d", ch_ts); if (ch_type == RSL_CHAN_SDCCH8_ACCH -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30378 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia8a101005d027fb5d0ddc2566f92ab2060f21c36 Gerrit-Change-Number: 30378 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: mobile: timeout_rr_meas(): use osmo_strbuf API

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30379 ) Change subject: mobile: timeout_rr_meas(): use osmo_strbuf API ...................................................................... mobile: timeout_rr_meas(): use osmo_strbuf API Change-Id: I0c505b753bcfb06d9f2f085d56d7d56fb1c44d50 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 16 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/79/30379/1 diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index 8e3b61b..08242ee 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -636,34 +636,37 @@ struct gsm_settings *set = &rr->ms->settings; int rxlev, berr, snr; uint8_t ch_type, ch_subch, ch_ts; + struct osmo_strbuf sb; char text[256]; + sb = (struct osmo_strbuf) { .buf = text, .len = sizeof(text) }; + /* don't monitor if no cell is selected or if we scan neighbour cells */ if (!cs->selected || cs->neighbour) { - sprintf(text, "MON: not camping on serving cell"); + OSMO_STRBUF_PRINTF(sb, "MON: not camping on serving cell"); goto restart; } else if (!meas->frames) { - sprintf(text, "MON: no cell info"); + OSMO_STRBUF_PRINTF(sb, "MON: no cell info"); } else { rxlev = (meas->rxlev + meas->frames / 2) / meas->frames; berr = (meas->berr + meas->frames / 2) / meas->frames; snr = (meas->snr + meas->frames / 2) / meas->frames; - sprintf(text, "MON: f=%d lev=%s snr=%2d ber=%3d " - "LAI=%s %s %04x ID=%04x", cs->sel_arfcn, - gsm_print_rxlev(rxlev), snr, berr, - gsm_print_mcc(cs->sel_mcc), - gsm_print_mnc(cs->sel_mnc), cs->sel_lac, cs->sel_id); + OSMO_STRBUF_PRINTF(sb, "MON: f=%d lev=%s snr=%2d ber=%3d " + "LAI=%s %s %04x ID=%04x", cs->sel_arfcn, + gsm_print_rxlev(rxlev), snr, berr, + gsm_print_mcc(cs->sel_mcc), + gsm_print_mnc(cs->sel_mnc), cs->sel_lac, cs->sel_id); if (rr->state == GSM48_RR_ST_DEDICATED) { - sprintf(text + strlen(text), " TA=%d pwr=%d", - rr->cd_now.ind_ta - set->alter_delay, - (set->alter_tx_power) ? set->alter_tx_power_value - : rr->cd_now.ind_tx_power); + OSMO_STRBUF_PRINTF(sb, " TA=%d pwr=%d", + rr->cd_now.ind_ta - set->alter_delay, + (set->alter_tx_power) ? set->alter_tx_power_value + : rr->cd_now.ind_tx_power); if (rsl_dec_chan_nr(rr->cd_now.chan_nr, &ch_type, &ch_subch, &ch_ts) == 0) { - sprintf(text + strlen(text), " TS=%d", ch_ts); + OSMO_STRBUF_PRINTF(sb, " TS=%d", ch_ts); if (ch_type == RSL_CHAN_SDCCH8_ACCH || ch_type == RSL_CHAN_SDCCH4_ACCH || ch_type == RSL_CHAN_Lm_ACCHs) - sprintf(text + strlen(text), "/%d", ch_subch); + OSMO_STRBUF_PRINTF(sb, "/%d", ch_subch); } } else gsm322_meas(rr->ms, rxlev); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30379 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0c505b753bcfb06d9f2f085d56d7d56fb1c44d50 Gerrit-Change-Number: 30379 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: mobile: timeout_rr_meas(): fix uninitialized variable

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30377 ) Change subject: mobile: timeout_rr_meas(): fix uninitialized variable ...................................................................... mobile: timeout_rr_meas(): fix uninitialized variable Change-Id: I956a1cafe9fed1a881574f59d0532e5cf931a1f7 Fixes: c9e579cea137fd147173434b7fa128d37685011 Fixes: CID#300084 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/77/30377/1 diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index 41aa7b8..b42ab3a 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -654,11 +654,12 @@ gsm_print_mcc(cs->sel_mcc), gsm_print_mnc(cs->sel_mnc), cs->sel_lac, cs->sel_id); if (rr->state == GSM48_RR_ST_DEDICATED) { - sprintf(text + strlen(text), " TA=%d pwr=%d TS=%d", + sprintf(text + strlen(text), " TA=%d pwr=%d", rr->cd_now.ind_ta - set->alter_delay, (set->alter_tx_power) ? set->alter_tx_power_value - : rr->cd_now.ind_tx_power, ch_ts); + : rr->cd_now.ind_tx_power); if (rsl_dec_chan_nr(rr->cd_now.chan_nr, &ch_type, &ch_subch, &ch_ts) == 0) { + sprintf(text + strlen(text), " TS=%d", ch_ts); if (ch_type == RSL_CHAN_SDCCH8_ACCH || ch_type == RSL_CHAN_SDCCH4_ACCH || ch_type == RSL_CHAN_Lm_ACCHs) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30377 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I956a1cafe9fed1a881574f59d0532e5cf931a1f7 Gerrit-Change-Number: 30377 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: rate_ctr: update estimation code

by pespin

Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30304 ) Change subject: rate_ctr: update estimation code ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: Fine with the refactoring here, but I'm still not convienced splitting 1 timerfd into 4 is needed nor a good idea. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30304 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I07232e9ff8bd62403ae82d9bd60d967d40b54ebc Gerrit-Change-Number: 30304 Gerrit-PatchSet: 7 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 11:11:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: rate_ctr: use multiple timerfd

by pespin

Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30303 ) Change subject: rate_ctr: use multiple timerfd ...................................................................... Patch Set 5: (1 comment) File src/rate_ctr.c: https://gerrit.osmocom.org/c/libosmocore/+/30303/comment/46979c5e_9598083a PS3, Line 441: rc = rate_ctr_init_timer(&rate_ctr_timer_sec, &ts_interval_sec, rate_ctr_timer_cb_sec); > How would you suggest to influence timer ordering? Influence timer ordering? I don't understand your question please rephrase. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I78da7119bb745c38eed011b3a8452797a1bfe9d4 Gerrit-Change-Number: 30303 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 11:10:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: rate_ctr: convert to timerfd

by pespin

Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30302 ) Change subject: rate_ctr: convert to timerfd ...................................................................... Patch Set 4: (1 comment) File src/rate_ctr.c: https://gerrit.osmocom.org/c/libosmocore/+/30302/comment/c2948534_67cc663c PS3, Line 359: timer_ticks++; > No, why would I do that? The timer_ticks is updated manually every time timer ticks (pun intended). […] yes, but if a timer is lost due to the CPU being too loaded, you still want to tick the lost event I guess? My understanding is that rate_ctr_group_intv() should be updated to take into account that timer_ticks can be increased more than once at a time, eg by storing last_timer_ticks, incrementing one vari ehre locally, passing it so that it can see if it lot the tick which should have updated it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0 Gerrit-Change-Number: 30302 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 11:09:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: osmo-ns-dummy: add ctrl interface

by pespin

Attention is currently required from: fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30300 ) Change subject: osmo-ns-dummy: add ctrl interface ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30300 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If6e06d9433e438b92f1ed1ef0f892308e031779b Gerrit-Change-Number: 30300 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 11:06:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022