November 2022 - gerrit-log - lists.osmocom.org

Change in docker-playground[master]: upgrade gerrit to 3.4.8

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/30382 ) Change subject: upgrade gerrit to 3.4.8 ...................................................................... upgrade gerrit to 3.4.8 Change-Id: I0be6e5f0c616b6c671635da62ba02afff2985592 --- M gerrit/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/82/30382/1 diff --git a/gerrit/Dockerfile b/gerrit/Dockerfile index 731ea6a..e3ddcb9 100644 --- a/gerrit/Dockerfile +++ b/gerrit/Dockerfile @@ -1,4 +1,4 @@ -FROM gerritcodereview/gerrit:3.4.5 +FROM gerritcodereview/gerrit:3.4.8 USER root RUN yum -y install zip unzip patch -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30382 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0be6e5f0c616b6c671635da62ba02afff2985592 Gerrit-Change-Number: 30382 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: paging: Optimize retrieving number of request per paging group

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30370 ) Change subject: paging: Optimize retrieving number of request per paging group ...................................................................... Patch Set 4: (1 comment) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30370/comment/d8bfdef6_4da51dd0 PS4, Line 93: bts_pag_st->initial_req_pgroup_counts[req->pgroup]--; > Note this will need to be moved as well if you change https://gerrit.osmocom. […] Yup, I already had this in mind thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6994127827d120a0b4dd3de51e1ddde39f2fe531 Gerrit-Change-Number: 30370 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 12:32:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: paging: Fix wrong count of reqs_before if queue only contains retrans...

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30362 ) Change subject: paging: Fix wrong count of reqs_before if queue only contains retransmissions ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > This patch doesn't really matter with the following one changing the handling (and making it much cl […] IMHO the fix is independent on whether the next patch is merged or not, and it includes more information on what was removed, so I'll keep it separate. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib2e810b0bcc51eac117713584310272462c58867 Gerrit-Change-Number: 30362 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 12:30:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: paging: Optimize retrieving number of request per paging group

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30370 ) Change subject: paging: Optimize retrieving number of request per paging group ...................................................................... Patch Set 4: (1 comment) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30370/comment/567773cc_7d7f3caa PS4, Line 93: bts_pag_st->initial_req_pgroup_counts[req->pgroup]--; Note this will need to be moved as well if you change https://gerrit.osmocom.org/c/osmo-bsc/+/30363/1/src/osmo-bsc/paging.c#263 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6994127827d120a0b4dd3de51e1ddde39f2fe531 Gerrit-Change-Number: 30370 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 12:23:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: paging: Replace reqs waiting for retransmission with new incoming ini...

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30347 ) Change subject: paging: Replace reqs waiting for retransmission with new incoming inital req if queue is full ...................................................................... Patch Set 6: (1 comment) File src/osmo-bsc/net_init.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30347/comment/c308fcc2_9438f188 PS6, Line 81: random Maybe just remove "random" here completely? I was looking through the code to find the call to rand until I noticed that it meant "whatever request happens to be the first in the retransmission queue". -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idfd93254ae456b1ee08416e05479488299dd063d Gerrit-Change-Number: 30347 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 12:21:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: paging: Fix wrong count of reqs_before if queue only contains retrans...

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30362 ) Change subject: paging: Fix wrong count of reqs_before if queue only contains retransmissions ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: This patch doesn't really matter with the following one changing the handling (and making it much clearer imo). I'd say you could squash it together with the next (still +1 if you decide against it) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib2e810b0bcc51eac117713584310272462c58867 Gerrit-Change-Number: 30362 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 12:16:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: jobs: new naming scheme for ftp.osmocom.org keys

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30381 ) Change subject: jobs: new naming scheme for ftp.osmocom.org keys ...................................................................... jobs: new naming scheme for ftp.osmocom.org keys Use new ssh keys for ftp.osmocom.org with consistent naming scheme. It was not possible to use @ in the ID name for new IDs, so I've used an underscore instead. Change-Id: Id0cf70e70944cf1a1963e0046b1470a0485c05f8 --- M jobs/osmocom-api.yml M jobs/osmocom-release-tarballs.yml 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/81/30381/1 diff --git a/jobs/osmocom-api.yml b/jobs/osmocom-api.yml index f91779d..132a1d6 100644 --- a/jobs/osmocom-api.yml +++ b/jobs/osmocom-api.yml @@ -15,7 +15,7 @@ wrappers: - ssh-agent-credentials: users: - - api@osmocom + - api_ftp.osmocom.org parameters: - string: name: BRANCH diff --git a/jobs/osmocom-release-tarballs.yml b/jobs/osmocom-release-tarballs.yml index 3d11bd3..fad7462 100644 --- a/jobs/osmocom-release-tarballs.yml +++ b/jobs/osmocom-release-tarballs.yml @@ -42,6 +42,6 @@ wrappers: - ssh-agent-credentials: users: - - releases + - releases_ftp.osmocom.org # vim: expandtab tabstop=2 shiftwidth=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id0cf70e70944cf1a1963e0046b1470a0485c05f8 Gerrit-Change-Number: 30381 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: jobs/master-builds: use binaries ssh credentials

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30380 ) Change subject: jobs/master-builds: use binaries ssh credentials ...................................................................... jobs/master-builds: use binaries ssh credentials Allow overriding the ssh agent credentials per repository, and use binaries_ftp.osmocom.org where needed. Use docs_ftp.osmocom.org instead of 97634b9d-a867-4f6d-825d-1da99813e93d so it's clear what the key is for. I generated a new one with the new ID. Fixes: OS#5798 Change-Id: I821968e09aaac3f6f6178de33fc909f81cb4abcb --- M jobs/master-builds.yml 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/80/30380/1 diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 17f576b..6a1ec09 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -49,6 +49,8 @@ trigger: email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org git_base_url: https://gerrit.osmocom.org + ssh: + - docs_ftp.osmocom.org # in alphabetical order repos: @@ -260,6 +262,9 @@ docker_img: 'registry.osmocom.org/$USER/fpga-build' cmd: 'docker pull {docker_img} && {docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org kredon(a)sysmocom.de 246tnt(a)gmail.com + ssh: + - binaries_ftp.osmocom.org + - docs_ftp.osmocom.org - osmo-fl2k: git_base_url: https://gitea.osmocom.org/sdr @@ -390,6 +395,9 @@ - osmo-asf4-dfu: cmd: '{docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org ewild(a)sysmocom.de + ssh: + - binaries_ftp.osmocom.org + - docs_ftp.osmocom.org - osmo-ccid-firmware: cmd: '{docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org ewild(a)sysmocom.de @@ -401,6 +409,9 @@ docker_img: '$USER/debian-bullseye-jenkins' cmd: '{docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org kredon(a)sysmocom.de + ssh: + - binaries_ftp.osmocom.org + - docs_ftp.osmocom.org - osmo-e1d - osmo-cbc @@ -533,7 +544,6 @@ send-to-individuals: true wrappers: - ssh-agent-credentials: - users: - - 97634b9d-a867-4f6d-825d-1da99813e93d + users: '{obj:ssh}' # vim: expandtab tabstop=2 shiftwidth=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30380 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I821968e09aaac3f6f6178de33fc909f81cb4abcb Gerrit-Change-Number: 30380 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: paging: Split paging queue into 2 queues: initial and retrans

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30363 ) Change subject: paging: Split paging queue into 2 queues: initial and retrans ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/5096a898_0ddb438d PS1, Line 263: bts_pag_st->initial_req_list_len--; > So you basically suggesting to move the -- and ++ lines inside paging_req_timeout_trans() within a " […] Yeah, same behavior, just more encapsulated. Otherwise it's +1 from me -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747 Gerrit-Change-Number: 30363 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 12:12:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: paging: Split paging queue into 2 queues: initial and retrans

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30363 ) Change subject: paging: Split paging queue into 2 queues: initial and retrans ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/7c1293f2_d2b0c38e PS1, Line 263: bts_pag_st->initial_req_list_len--; > You already adjust the *_list_len accordingly in paging_remove_request(). […] So you basically suggesting to move the -- and ++ lines inside paging_req_timeout_trans() within a "if (req->attempts==0)" conditional block, right? So same behavior in the end, just different place. I can do that, it may be clearer for people when reading the lifecycle of requests across the different lists. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747 Gerrit-Change-Number: 30363 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Nov 2022 12:10:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022