January 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: conv: Fix the traceback for tail biting codes

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26657 ) Change subject: conv: Fix the traceback for tail biting codes ...................................................................... Patch Set 3: > Heh, I don't like the linter comments and it makes it inconsistent with the surrouding code :/ My plan is to re-format after merging this patch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I87e51d3880c0fe7bf3d6cd08fd46517a424a230c Gerrit-Change-Number: 26657 Gerrit-PatchSet: 3 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jan 2022 20:15:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: iuup: Submit RNL-STATUS-Initialization.ind upon rx of Init

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26721 ) Change subject: iuup: Submit RNL-STATUS-Initialization.ind upon rx of Init ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I63ee780b4aa162ea097410b234e73984000c0965 Gerrit-Change-Number: 26721 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 05 Jan 2022 20:14:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmo-netif[master]: amr: Fix FormatType from parsing BWE AMR header

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26787 ) Change subject: amr: Fix FormatType from parsing BWE AMR header ...................................................................... amr: Fix FormatType from parsing BWE AMR header The proper order is CMR(4)+F(1)+FT(4)+Q(1). Hence, FT is 3 least significant bits of first byte and 1 most significant bit of secont byte. Change-Id: I66f39d3b9a608f07c202e7a5084a8537e9978a94 --- M src/amr.c M tests/amr/amr_test.c 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/87/26787/1 diff --git a/src/amr.c b/src/amr.c index 1cb2ccc..2df6967 100644 --- a/src/amr.c +++ b/src/amr.c @@ -236,7 +236,7 @@ return -1; /* Calculate new payload length */ - ft = (payload[0] & 0xf0) >> 4; + ft = ((payload[0] & 0x07) << 1) | ((payload[1] & 0x80) >> 7); if (!osmo_amr_ft_valid(ft)) return -1; diff --git a/tests/amr/amr_test.c b/tests/amr/amr_test.c index fc579e9..802fbee 100644 --- a/tests/amr/amr_test.c +++ b/tests/amr/amr_test.c @@ -230,7 +230,8 @@ OSMO_ASSERT(rc == len + 2); printf(" BE: %d bytes (%s),", rc, osmo_hexdump(buf, rc)); - buf[0] = (ft << 4) & 0xf0; + buf[0] = (ft >> 1) & 0x07; + buf[1] = ((ft & 0x01) << 7) | (buf[1] & 0x3f); rc = osmo_amr_bwe_to_iuup(buf, rc); printf(" IuUP: %d bytes\n", rc); OSMO_ASSERT(rc > 0); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I66f39d3b9a608f07c202e7a5084a8537e9978a94 Gerrit-Change-Number: 26787 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

2
2
0 0

Change in libosmo-netif[master]: amr: Fix length check in osmo_amr_bwe_to_iuup

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26788 ) Change subject: amr: Fix length check in osmo_amr_bwe_to_iuup ...................................................................... amr: Fix length check in osmo_amr_bwe_to_iuup The check was wrong for format types containing extra bits not aligned to byte boundaries, such as FT7 (AMR Code 12.20, 244 bits, 31 bytes). if the source has 1-6 extra bits, they can be fit with one less byte when shifting 10 bits to the left. Change-Id: I0552d727585886d25f613e64ca815fb6dcd53f25 --- M src/amr.c 1 file changed, 9 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/88/26788/1 diff --git a/src/amr.c b/src/amr.c index 2df6967..ed92f30 100644 --- a/src/amr.c +++ b/src/amr.c @@ -228,8 +228,8 @@ int osmo_amr_bwe_to_iuup(uint8_t *payload, unsigned int payload_len) { /* The header is only valid after shifting first two bytes to OA mode */ - unsigned int i; - unsigned int amr_speech_len; + unsigned int i, required_len; + unsigned int amr_speech_len_bytes, amr_speech_len_bits; uint8_t ft; if (payload_len < 2) @@ -240,16 +240,19 @@ if (!osmo_amr_ft_valid(ft)) return -1; - amr_speech_len = osmo_amr_bytes(ft); - if (payload_len < amr_speech_len + 2) + amr_speech_len_bits = osmo_amr_bits(ft); + amr_speech_len_bytes = osmo_amr_bytes(ft); + + required_len = amr_speech_len_bits + 10; /* shift of 10 bits */ + if (payload_len < (required_len + 7)/8) return -1; - for (i = 0; i < amr_speech_len; i++) { + for (i = 0; i < amr_speech_len_bytes; i++) { /* we have to shift the payload by 10 bits to get only the Class A, B, C bits */ payload[i] = (payload[i + 1] << 2) | ((payload[i + 2]) >> 6); } - return amr_speech_len; + return amr_speech_len_bytes; } /*! Convert an AMR frame from IuuP/IuFP payload to bandwith-efficient mode. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0552d727585886d25f613e64ca815fb6dcd53f25 Gerrit-Change-Number: 26788 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

2
3
0 0

Change in docker-playground[master]: Use osmo-hnbgw from osmo-hnbgw.git instead of osmo-iuh.git

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26784 ) Change subject: Use osmo-hnbgw from osmo-hnbgw.git instead of osmo-iuh.git ...................................................................... Use osmo-hnbgw from osmo-hnbgw.git instead of osmo-iuh.git Starting with release 1.2.0 of both repos, osmo-hnbgw binary is in osmo-hnbgw.git, not osmo-iuh.git anymore. Change-Id: I4ac6ede6a5b25ada211674bf3c46d79d7720a4bc --- M make/Makefile M osmo-bisect.sh M osmo-hnbgw-master/Dockerfile 3 files changed, 12 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/84/26784/1 diff --git a/make/Makefile b/make/Makefile index 8bd360d..e314618 100644 --- a/make/Makefile +++ b/make/Makefile @@ -26,6 +26,7 @@ OSMO_GGSN_BRANCH?=master OSMO_GSM_TESTER_BRANCH?=master OSMO_HLR_BRANCH?=master +OSMO_HNBGW_BRANCH?=master OSMO_HNODEB_BRANCH?=master OSMO_IUH_BRANCH?=master OSMO_MGW_BRANCH?=master @@ -101,6 +102,7 @@ --build-arg OSMO_GGSN_BRANCH=$(OSMO_GGSN_BRANCH) \ --build-arg OSMO_GSM_TESTER_BRANCH=$(OSMO_GSM_TESTER_BRANCH) \ --build-arg OSMO_HLR_BRANCH=$(OSMO_HLR_BRANCH) \ + --build-arg OSMO_HNBGW_BRANCH=$(OSMO_HNBGW_BRANCH) \ --build-arg OSMO_HNODEB_BRANCH=$(OSMO_HNODEB_BRANCH) \ --build-arg OSMO_IUH_BRANCH=$(OSMO_IUH_BRANCH) \ --build-arg OSMO_MGW_BRANCH=$(OSMO_MGW_BRANCH) \ diff --git a/osmo-bisect.sh b/osmo-bisect.sh index 5ca69cd..68ece72 100755 --- a/osmo-bisect.sh +++ b/osmo-bisect.sh @@ -20,10 +20,7 @@ COMMIT=$(git log -1 --format=format:%H) case $COMP_LOWER in - "hnbgw") - BRANCH="OSMO_IUH_BRANCH" - SUITE="ttcn3-hnbgw-test" - ;; + "hnbgw"|\ "bsc"|\ "bts"|\ "ggsn"|\ diff --git a/osmo-hnbgw-master/Dockerfile b/osmo-hnbgw-master/Dockerfile index 9101e0c..06c16b2 100644 --- a/osmo-hnbgw-master/Dockerfile +++ b/osmo-hnbgw-master/Dockerfile @@ -10,19 +10,22 @@ libosmo-abis-dev \ libosmo-netif-dev \ libosmo-sigtran-dev \ + libosmo-ranap-dev \ + libosmo-rua-dev \ + libosmo-hnbap-dev \ libasn1c-dev && \ apt-get clean WORKDIR /tmp -ARG OSMO_IUH_BRANCH="master" +ARG OSMO_HNBGW_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-iuh.git -ADD http://git.osmocom.org/osmo-iuh/patch?h=$OSMO_IUH_BRANCH /tmp/commit-osmo-mgw +RUN git clone git://git.osmocom.org/osmo-hnbgw.git +ADD http://git.osmocom.org/osmo-iuh/patch?h=$OSMO_HNBGW_BRANCH /tmp/commit-osmo-hnbgw -RUN cd osmo-iuh && \ - git fetch && git checkout $OSMO_IUH_BRANCH && \ - (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_IUH_BRANCH || exit 1); \ +RUN cd osmo-hnbgw && \ + git fetch && git checkout $OSMO_HNBGW_BRANCH && \ + (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_HNBGW_BRANCH || exit 1); \ git rev-parse --abbrev-ref HEAD && git rev-parse HEAD && \ autoreconf -fi && \ ./configure && \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26784 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4ac6ede6a5b25ada211674bf3c46d79d7720a4bc Gerrit-Change-Number: 26784 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

1
2
0 0

Change in osmo-ci[master]: Add new repo osmo-hnbgw (latest) to build jobs and scripts

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26783 ) Change subject: Add new repo osmo-hnbgw (latest) to build jobs and scripts ...................................................................... Add new repo osmo-hnbgw (latest) to build jobs and scripts Change-Id: I634ebbfa7f471342ffcf253fdb8a316f5e71089f --- M scripts/common.sh M scripts/osmocom-latest-packages.sh 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/83/26783/1 diff --git a/scripts/common.sh b/scripts/common.sh index 9e629a6..e8603a3 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -24,6 +24,7 @@ osmo-gsm-manuals osmo-hlr osmo-hnodeb + osmo-hnbgw osmo-iuh osmo-mgw osmo-msc @@ -39,7 +40,6 @@ osmocom-bb simtrace2 " -#^TODO: still no release made: osmo-hnbgw OSMO_BRANCH_DOCKER_PLAYGROUND="${OSMO_BRANCH_DOCKER_PLAYGROUND:-master}" diff --git a/scripts/osmocom-latest-packages.sh b/scripts/osmocom-latest-packages.sh index 90b9e28..18f9420 100755 --- a/scripts/osmocom-latest-packages.sh +++ b/scripts/osmocom-latest-packages.sh @@ -195,7 +195,7 @@ checkout osmo-cbc checkout osmo-gbproxy checkout osmo-hnodeb - #checkout osmo-hnbgw + checkout osmo-hnbgw cd "$TOP" @@ -234,7 +234,7 @@ build osmo-cbc build osmo-gbproxy build osmo-hnodeb - #build osmo-hnbgw + build osmo-hnbgw cd "$TOP/$PROJ" osc ci -m "$FEED versions of $DT" --noservice -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26783 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I634ebbfa7f471342ffcf253fdb8a316f5e71089f Gerrit-Change-Number: 26783 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

1
2
0 0

Change in osmo-iuh[master]: Bump version: 1.1.0.5-a3c2 → 1.2.0

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26782 ) Change subject: Bump version: 1.1.0.5-a3c2 → 1.2.0 ...................................................................... Bump version: 1.1.0.5-a3c2 → 1.2.0 This version is basically 1.1.0 with osmo-hnbgw dropped, which was moved to osmo-hnbgw.git and released as 1.2.0 there. Change-Id: I63afc9d98cfc1d478ff2853adf5224e5f383186c --- M debian/changelog 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/82/26782/1 diff --git a/debian/changelog b/debian/changelog index 93593f0..2c8123c 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,16 @@ +osmo-iuh (1.2.0) unstable; urgency=medium + + [ Oliver Smith ] + * treewide: remove FSF address + + [ Pau Espin Pedrol ] + * tests/tests_common.c: Add missing header + * Introduce dynamic log category for libosmo-rua/hnbap + * Drop osmo-hnbgw + * tests/dummy_cn_sua.c: Drop no longer existing include + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Wed, 05 Jan 2022 12:26:51 +0100 + osmo-iuh (1.1.0) unstable; urgency=medium * gitignore: Ignore libsmo-{hnbap,rua}.pc -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I63afc9d98cfc1d478ff2853adf5224e5f383186c Gerrit-Change-Number: 26782 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

1
2
0 0

Change in osmo-iuh[master]: tests/dummy_cn_sua.c: Drop no longer existing include

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26781 ) Change subject: tests/dummy_cn_sua.c: Drop no longer existing include ...................................................................... tests/dummy_cn_sua.c: Drop no longer existing include This one was unspotted during last patches dropping hnbgw since this file is actually not compiled currently. Change-Id: I94ed20c42bcc9619d80757c6ff4a661c360bfb4f --- M src/tests/dummy_cn_sua.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/81/26781/1 diff --git a/src/tests/dummy_cn_sua.c b/src/tests/dummy_cn_sua.c index 6e14562..cf71608 100644 --- a/src/tests/dummy_cn_sua.c +++ b/src/tests/dummy_cn_sua.c @@ -24,7 +24,6 @@ #include <osmocom/ranap/ranap_ies_defs.h> #include <osmocom/ranap/ranap_common_cn.h> #include <osmocom/ranap/ranap_msg_factory.h> -#include <osmocom/iuh/hnbgw.h> const char *cmdline_bind_addr = "127.0.0.1"; -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I94ed20c42bcc9619d80757c6ff4a661c360bfb4f Gerrit-Change-Number: 26781 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

1
2
0 0

Change in osmo-hnbgw[master]: Bump version: 0.0.0 → 1.2.0

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/26780 ) Change subject: Bump version: 0.0.0 → 1.2.0 ...................................................................... Bump version: 0.0.0 → 1.2.0 Change-Id: Ie851ebe7c67cd91e2f3188cea4221ab9c33c7662 --- M debian/changelog 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/80/26780/1 diff --git a/debian/changelog b/debian/changelog index c4bf3b0..d181aff 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +osmo-hnbgw (1.2.0) unstable; urgency=medium + + * Initial structure + import code from osmo-iuh.git + * Populate debian/changelog to avoid build failures + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Wed, 05 Jan 2022 12:17:16 +0100 + osmo-hnbgw (0.0.0) unstable; urgency=medium * Initial debian package -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/26780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie851ebe7c67cd91e2f3188cea4221ab9c33c7662 Gerrit-Change-Number: 26780 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

1
2
0 0

Change in osmo-hnbgw[master]: Populate debian/changelog to avoid build failures

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/26778 ) Change subject: Populate debian/changelog to avoid build failures ...................................................................... Populate debian/changelog to avoid build failures An empty debian/changelog is illegal and makes dpkg-buildpackage fail. Change-Id: I4b9b0a89c6aa92fd5fed29af831741019719df6d --- M debian/changelog 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/78/26778/1 diff --git a/debian/changelog b/debian/changelog index 8b13789..c4bf3b0 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1 +1,5 @@ +osmo-hnbgw (0.0.0) unstable; urgency=medium + * Initial debian package + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Wed, 05 Jan 2022 11:58:28 +0200 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/26778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I4b9b0a89c6aa92fd5fed29af831741019719df6d Gerrit-Change-Number: 26778 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

1
2
0 0

2025

2024

2023

2022

gerrit-log January 2022