Attention is currently required from: fixeria.
fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/docker-playground/+/26982 )
Change subject: osmo-uecups-master/Dockerfile: do not pass command line options
......................................................................
osmo-uecups-master/Dockerfile: do not pass command line options
Change-Id: Ia9b220e4cfbc89b800fafdd153bd63d6d95799e2
Related: SYS#5602
---
M osmo-uecups-master/Dockerfile
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/82/26982/2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26982
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ia9b220e4cfbc89b800fafdd153bd63d6d95799e2
Gerrit-Change-Number: 26982
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26998 )
Change subject: fw/qmod: enable modem RESET by default at boot
......................................................................
fw/qmod: enable modem RESET by default at boot
When the uC firmware starts, assert the (high-active) _RESET GPIOs,
which will cause the transistors to drive the mPCIe slot !PERST
low.
There is of course a short instance of time between the uC reset
until it executes wwan_perst_init(). To avoid this, a hardware
pull-up would have to be re-worked onto the _RESET[1..4] signals
on the PCBA
Change-Id: I8742fefa4bf02e728e34d5d8cbc0fda771e78ffb
---
M firmware/libboard/qmod/include/board.h
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/98/26998/1
diff --git a/firmware/libboard/qmod/include/board.h b/firmware/libboard/qmod/include/board.h
index 7ea5bd7..56d0d21 100644
--- a/firmware/libboard/qmod/include/board.h
+++ b/firmware/libboard/qmod/include/board.h
@@ -89,8 +89,8 @@
#define PINS_WWAN_IN { PIN_WWAN1, PIN_WWAN2 }
/* outputs controlling RESET input of modems */
-#define PIN_PERST1 {PIO_PA25, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_PULLUP}
-#define PIN_PERST2 {PIO_PA26, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_PULLUP}
+#define PIN_PERST1 {PIO_PA25, PIOA, ID_PIOA, PIO_OUTPUT_1, PIO_PULLUP}
+#define PIN_PERST2 {PIO_PA26, PIOA, ID_PIOA, PIO_OUTPUT_1, PIO_PULLUP}
#define PINS_PERST { PIN_PERST1, PIN_PERST2 }
#define PIN_VERSION_DET {PIO_PA19, PIOA, ID_PIOA, PIO_PERIPH_D, PIO_DEFAULT}
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26998
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I8742fefa4bf02e728e34d5d8cbc0fda771e78ffb
Gerrit-Change-Number: 26998
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26955 )
Change subject: ranap_common_ran: add decoder for RAN/RNC originated messages
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
I agree with the linter, and the copyright statement needs updating. Apart from that: LGTM!
File src/ranap_common_ran.c:
https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/2081160c_21731956
PS1, Line 3: /
I didn't write this, right? I guess it should be (C) sysmocom Author: pmaier
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26955
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: Iad4c2743d4d1ddf8ad49002d1fe6866f22eb9e98
Gerrit-Change-Number: 26955
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Jan 2022 16:47:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment