Attention is currently required from: pespin, fixeria.
falconia has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32962 )
Change subject: gsm0503_tch_hr_decode2(): new function, emits TS101318 format
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Do you plan to submit patches for current
gsm0503_tch_hr_decode() users to migrate to gsm0503_tch_hr […]
osmo-bts-trx: yes, as
detailed in my "blueprint" comment in the OS#5688 ticket.
trxcon: I do not feel qualified to touch that one, but I realize that I become kinda
responsible for transitioning it into the state of using a deprecated API. Calling out to
@fixeria - Vadim, *if* you agree in principle with my approach to OS#5688, would you be
willing to work with me on bringing trxcon (and the path feeding the resulting HR codec
frames to gapk) into alignment?
File include/osmocom/coding/gsm0503_coding.h:
https://gerrit.osmocom.org/c/libosmocore/+/32962/comment/1dfd48f5_6a821334
PS1, Line 52: int gsm0503_tch_hr_decode(uint8_t *tch_data, const sbit_t *bursts, int odd,
mark as OSMO_DEPRECATED?
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32962
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If28ddb20789e8993b7558ca08020478615b4c708
Gerrit-Change-Number: 32962
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 23 May 2023 16:32:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment