Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39193?usp=email ) Change subject: construct: allow stripping of leading zeros with StripHeaderAdapter ...................................................................... Patch Set 5: (1 comment) File src/osmocom/construct.py: https://gerrit.osmocom.org/c/python/pyosmocom/+/39193/comment/b2c0393c_a9f4… : PS4, Line 466: :[ I was thinking that this were correct, but I am not so sure about this anymore. I can not find any reference that would confirm if it is correct, so its probably wrong. (I wonder why the linter didn't complain) In this module we have only import typing, and we use typing.Xyz, so I have changed it to that style. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I1a9fff17abbbef0c5f6d45f58198debfa12e78b6 Gerrit-Change-Number: 39193 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 03 Jan 2025 16:54:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>