Attention is currently required from: laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39193?usp=email )
Change subject: construct: allow stripping of leading zeros with StripHeaderAdapter ......................................................................
Patch Set 5:
(1 comment)
File src/osmocom/construct.py:
https://gerrit.osmocom.org/c/python/pyosmocom/+/39193/comment/b2c0393c_a9f44... : PS4, Line 466: :[
are you sure about that "[int]" sytntax? We usually use List[int] so far, following "from typing im […]
I was thinking that this were correct, but I am not so sure about this anymore. I can not find any reference that would confirm if it is correct, so its probably wrong. (I wonder why the linter didn't complain)
In this module we have only import typing, and we use typing.Xyz, so I have changed it to that style.