Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36456?usp=email ) Change subject: msc: rework f_expect_paging(): handle mismatch and timeout ...................................................................... Patch Set 2: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36456/comment/4b37daad_0312… PS2, Line 13: Done File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36456/comment/d071326a_4e32… PS2, Line 1362: [g_pars.ran_is_geran] BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi, tmsi)); Resolved in the new patchset. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36456/comment/adb01b48_8573… PS2, Line 1366: function f_expect_paging(template OCT4 tmsi := *, float Tval := 4.0) Yes, a generic API for expecting the given message template would be nice. The problem with paging, though, is that it's not just one template but actually two different PDU types and thus two templates. So a generic `f_expect_foo()` API would need to accept two templates: one for GERAN and one for UTRAN. While this approach might work, I believe having `f_expect_paging[_tmsi]()` and smaller altsteps (see next change) is a pretty good abstraction already, despite not being implemented using a generic `f_expect_foo()` API. Imagine doing this every time you expect paging: ``` f_expect_foo(geran := tr_BSSMAP_Paging(g_pars.imsi, g_pars.tmsi), utran := tr_RANAP_Paging(cs_domain, imsi_hex2oct(g_pars.imsi))); ``` Calling `f_expect_paging()` is a lot shorter and self-explanatory. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36456?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I30273e3882e348a2ded88b7b96a5ec1473a56913 Gerrit-Change-Number: 36456 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sun, 14 Apr 2024 20:13:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment