Attention is currently required from: Hoernchen, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32022 )
Change subject: layer23: modem: Test GMM layer through VTY ......................................................................
Patch Set 1:
(4 comments)
File src/host/layer23/src/modem/gmm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/32022/comment/1347d5bf_d716b6d3 PS1, Line 92: rc = 1; Just do `return 1` straight away, `rc` is not really needed?
File src/host/layer23/src/modem/llc.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/32022/comment/24734b73_b147cf7a PS1, Line 62: rc = osmo_gprs_gmm_prim_llc_lower_up(llc_prim); Same here, you're assigning `rc` but then unconditionally overwriting it?
File src/host/layer23/src/modem/vty.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/32022/comment/45e41c85_a16afbaf PS1, Line 159: LLC_CMDG_DESC copy-paste, you should add `GMM_CMDG_DESC`.
https://gerrit.osmocom.org/c/osmocom-bb/+/32022/comment/cc9ce62f_2d56432c PS1, Line 161: "Hard-coded GMM Attach Request (SAPI=GMM, TLLI=0xe1c5d364)\n") Something is wrong here, what part of the command this docstring corresponds to?
-
fixeria