Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 3: (408 comments) File Transceiver52M/ms/bladerf_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba8b0baa_cc5224e6 PS3, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ea5a549_5e132e96 PS3, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e1171cda_c5a690a8 PS3, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a227c8ce_9c3eb6c4 PS3, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9d1390a7_2fd4c30b PS3, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e01b625a_c1744783 PS3, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1feed99_d573da8b PS3, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c994dd2f_ac76abde PS3, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8b37c0ad_3f397823 PS3, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/29fcfe2c_12eb8da6 PS3, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2f9048eb_2485c549 PS3, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/54d4576e_51378b22 PS3, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4bd5af4_6aaad064 PS3, Line 52: template <class R, class... Args> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5feefac5_a07a24a5 PS3, Line 52: template <class R, class... Args> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/990925f3_d997a82c PS3, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/16d85c35_d6839e2b PS3, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/55f935b3_8f1f7261 PS3, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/691bf1e1_ca297b28 PS3, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ca1f471a_0123b27d PS3, Line 57: if (rval != 0) { suspect code indent for conditional statements (8, 26) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/daf3b8ac_0cf13f09 PS3, Line 58: std::cerr << ((rval >= 0) ? "OK:" : bladerf_strerror(rval)) << ':' << finame << ':' << line << ':' labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d3326e0_dd27a2f7 PS3, Line 66: #define blade_check(func, ...) exec_and_check(func, #func, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__) __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e5f6c7d9_c4fccb2b PS3, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ec0b9219_6bb24672 PS3, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd886d35_8e006dd9 PS3, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a1491bb_0ddfe138 PS3, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/981325ad_a475ddbc PS3, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c68e9996_8b126a4b PS3, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7bb7e3f3_6ce98626 PS3, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/75029840_7841d8d9 PS3, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c4879256_cc0d47b5 PS3, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0a917ac_0f5bbe43 PS3, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ebb64aba_7ad26910 PS3, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d0b57cd_c409917d PS3, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8b0f881f_b7366e7e PS3, Line 83: int actual_samples_per_msg() Bad function definition - int actual_samples_per_msg() should probably be int actual_samples_per_msg(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6931c674_bf35d054 PS3, Line 83: int actual_samples_per_msg() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d36167f7_d4262f3f PS3, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f81910fd_db9b9691 PS3, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02d8b1ef_cdef212e PS3, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d1041f7e_03662dc3 PS3, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ded46a75_4e8244fe PS3, Line 87: int actual_samples_per_buffer() Bad function definition - int actual_samples_per_buffer() should probably be int actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b36b03b3_c26a3a3f PS3, Line 87: int actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5ad0f057_c673f117 PS3, Line 91: int samples_per_buffer() Bad function definition - int samples_per_buffer() should probably be int samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f79c4051_50e75fd4 PS3, Line 91: int samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/39abcdb8_5fded511 PS3, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ad0e3eb6_7cb9145e PS3, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8c64d23d_e773b03f PS3, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9674b9e7_bd870d1d PS3, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d544a74a_86f6e043 PS3, Line 95: int num_msgs_per_buffer() Bad function definition - int num_msgs_per_buffer() should probably be int num_msgs_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0eb47131_06b66f43 PS3, Line 95: int num_msgs_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc9b7289_513d9183 PS3, Line 99: auto get_first_ts() Bad function definition - auto get_first_ts() should probably be auto get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f73c6c4_67b3edc3 PS3, Line 99: auto get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a2c8415_cdd50fe3 PS3, Line 103: constexpr auto *getsampleoffset(int ofs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4034d376_285b9bbd PS3, Line 109: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6ee28aa_e4d2c9d3 PS3, Line 118: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c7a0061f_02a27a43 PS3, Line 156: int write_n_burst(blade_sample_type *in, int num, uint64_t first_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0cfba239_a4207e81 PS3, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/657a6cfd_75bb5b36 PS3, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0260057_077b235f PS3, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e1beaf79_33ccdf24 PS3, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f051ce8_cc48d68c PS3, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/29329646_6c8d99c0 PS3, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86ca7775_6812e59c PS3, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc345c1a_cce44b35 PS3, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f47cc868_1895eeb1 PS3, Line 185: template <typename T> struct blade_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3214031c_d7efc070 PS3, Line 185: template <typename T> struct blade_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cc44a38c_7fabb7f1 PS3, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ddeb7121_f16328df PS3, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b82b7796_04223e41 PS3, Line 202: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ec08b7ae_debe9d0c PS3, Line 223: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8bab2c6d_7f3e1e93 PS3, Line 223: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/42a65e8a_6abb3023 PS3, Line 242: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/24ebeb49_30800d27 PS3, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ff697468_d3417e60 PS3, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e846e1e4_4c6f3a24 PS3, Line 250: std::cerr << "open failed, device missing?" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/119dc541_2c0ed57e PS3, Line 254: std::cerr << "open failed, only superspeed (usb3) supported!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d354ab4_24deabf0 PS3, Line 271: std::cerr << "unable to lock refclk!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/117fb990_e2f8e338 PS3, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49590da0_ff770364 PS3, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0445a94c_e5911f13 PS3, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/25362f18_6346e42c PS3, Line 316: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/27e770bd_aa56f365 PS3, Line 318: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/42ba2f14_c63b9c44 PS3, Line 320: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e51145d_f8f36aa1 PS3, Line 323: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3610503_042fc96e PS3, Line 325: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0a6ef1a8_f4fa6aae PS3, Line 327: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/821fa3e5_3b06513a PS3, Line 330: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a15c78ac_1c0a22ca PS3, Line 335: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/390992bc_1f130e0f PS3, Line 338: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5be12e54_60191e4a PS3, Line 340: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/923b289f_132d9225 PS3, Line 343: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba084ab9_3bf5a1c6 PS3, Line 346: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8566624f_7d22d454 PS3, Line 348: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2b292305_a4471848 PS3, Line 351: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/287a7c2d_8fbb49da PS3, Line 356: static void check_timestamp(dev_buf_t *rcd) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18bd6c62_8512d5e0 PS3, Line 363: } else if (last_ts + rcd->actual_samples_per_buffer() != rcd->m[0].ts) { suspect code indent for conditional statements (16, 34) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4bf690c_0668cd2c PS3, Line 364: std::cerr << "RX Overrun!" << last_ts << " " << rcd->actual_samples_per_buffer() << " " labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/40f4c20f_8f1f005b PS3, Line 372: bladerf_stream_cb getrxcb(bh_fn_t rxbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2eb06af3_1f75154c PS3, Line 376: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1249c3b9_4f577da2 PS3, Line 377: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/640852e3_61ca29bd PS3, Line 392: bladerf_stream_cb gettxcb(bh_fn_t txbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0019793b_c364da36 PS3, Line 396: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6d0805d_f1234cbe PS3, Line 397: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/37866471_03c18272 PS3, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fe00b8cc_ff49cc04 PS3, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ec06a734_9896ef53 PS3, Line 408: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aef59f4e_da266579 PS3, Line 410: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11132b87_e1b03d57 PS3, Line 414: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3d4eb73e_728c0516 PS3, Line 420: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ad52825_01ef6467 PS3, Line 422: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0dc16bbd_ec80111f PS3, Line 426: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba3e7025_d6cdd5ca PS3, Line 433: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bbbb7d6b_bff63695 PS3, Line 435: //get empty bufer from list 'bufer' may be misspelled - perhaps 'buffer'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fcb52d46_3c5b391b PS3, Line 436: tx_buf_q_type::elem_t rcd; labels should not be indented File Transceiver52M/ms/ipc_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/914548e4_6cfec982 PS3, Line 38: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4e1cd58_686b327c PS3, Line 38: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7edcf6e3_57ca4c37 PS3, Line 45: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ffceee11_6b59f90d PS3, Line 45: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/66196f55_533c4cb3 PS3, Line 49: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd96e752_f398f0f2 PS3, Line 49: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0bbc627c_eb69c788 PS3, Line 53: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3e506ed_0a4b3d3b PS3, Line 58: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb0b01f3_4a4c1507 PS3, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/55a1f448_6cd64b3e PS3, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c04aeb8d_b86bb002 PS3, Line 71: template <typename T> struct ipc_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/af9b8f93_8d0147be PS3, Line 71: template <typename T> struct ipc_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/26a9e62a_a7034855 PS3, Line 76: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c2e0f29c_c4582754 PS3, Line 76: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a136e69_cc4b306a PS3, Line 76: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/deab6179_bdb67879 PS3, Line 76: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f02102b9_be01c97b PS3, Line 92: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/da14af62_34ee9566 PS3, Line 99: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/14cbe96b_3188668e PS3, Line 106: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/41519892_cd3937c1 PS3, Line 111: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7f2beeed_86859d26 PS3, Line 119: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/becf3c31_1654ff46 PS3, Line 127: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4f9fd20_a08996bf PS3, Line 132: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4428091_102e6d57 PS3, Line 137: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8f2d068_e240070a PS3, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f99df907_8d85636f PS3, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3222a247_3c7ae87a PS3, Line 164: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c59289ee_50d68ac7 PS3, Line 166: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/839b7491_a930c174 PS3, Line 175: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31343549_a46ac0a1 PS3, Line 177: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd0e1b8c_f7bd9940 PS3, Line 183: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/140e10c9_0648d5b2 PS3, Line 188: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f921479a_3380381b PS3, Line 193: void signal_start() Bad function definition - void signal_start() should probably be void signal_start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/231f3f5c_07d6310b PS3, Line 193: void signal_start() open brace '{' following function definitions go on the next line File Transceiver52M/ms/itrq.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c82aec61_39991c07 PS3, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5c2bb9a2_d975b158 PS3, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9e74b49c_246238c0 PS3, Line 52: std::condition_variable cond_r, cond_w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c944dff1_d38376db PS3, Line 53: std::mutex lr, lw; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/60d3bb97_2eda81dc PS3, Line 54: std::atomic_int r_flag, w_flag; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f3c8a6c_49cdfe42 PS3, Line 56: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/150cabb2_814ac186 PS3, Line 57: explicit spsc_cond_detail() : r_flag(0), w_flag(0) Bad function definition - explicit spsc_cond_detail() should probably be explicit spsc_cond_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/87ab023b_049880b1 PS3, Line 65: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5da13b7c_26e856d5 PS3, Line 65: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4ad57fe6_b9b2bf96 PS3, Line 67: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78db5da9_355c999b PS3, Line 67: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d31a1b3d_40323c31 PS3, Line 67: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd0492ef_5ff6b31b PS3, Line 73: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9e86920b_e633b0f8 PS3, Line 73: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cf73cf7b_258b5d71 PS3, Line 75: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76ff7026_072913b1 PS3, Line 75: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1d283347_cf89dcb4 PS3, Line 75: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11d83567_bc6dd09c PS3, Line 81: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c4108089_44011c20 PS3, Line 81: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5cd34243_60a3917b PS3, Line 83: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/50a73c19_97eb9038 PS3, Line 83: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ec33dd04_9c39d3ff PS3, Line 83: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c996c184_ae7f06b4 PS3, Line 87: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8b41cf42_be3ae62b PS3, Line 87: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/87e9395d_c3b97e37 PS3, Line 89: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a979ef5_5fd5f50f PS3, Line 89: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d087f75_3e2b035c PS3, Line 89: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c5447f3b_c40efb11 PS3, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/909805c3_cb26d06d PS3, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/74f817d1_965b9057 PS3, Line 99: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/69d429f5_aef5217a PS3, Line 100: explicit spsc_efd_detail() Bad function definition - explicit spsc_efd_detail() should probably be explicit spsc_efd_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ededf509_8ad31777 PS3, Line 111: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/291b5beb_f3ce3c4e PS3, Line 111: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7325abb_14a22683 PS3, Line 116: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3a1dcc9_962c42e2 PS3, Line 116: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/12b28d8c_4e8238ee PS3, Line 121: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99b1025f_2ad1e918 PS3, Line 121: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e97e714a_073182e0 PS3, Line 126: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/05d71af1_0f79790b PS3, Line 126: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3c0c25c1_5716bb37 PS3, Line 131: int get_r_efd() Bad function definition - int get_r_efd() should probably be int get_r_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd03e987_e49774e9 PS3, Line 131: int get_r_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/72424a9e_31ec39fd PS3, Line 135: int get_w_efd() Bad function definition - int get_w_efd() should probably be int get_w_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/872613ad_69e513c8 PS3, Line 135: int get_w_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5cc4aaf2_1d95ff34 PS3, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bde04339_af3c4eae PS3, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/95ee10a7_7f669cc1 PS3, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1e068dbf_9f4f59df PS3, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c0b58272_93487ec3 PS3, Line 142: class spsc : public T<block_read, block_write> { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f115708_44edfe3c PS3, Line 142: class spsc : public T<block_read, block_write> { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0b1e36a_d7234f23 PS3, Line 144: std::atomic<unsigned int> readptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ca3d48f_52ccd40b PS3, Line 144: std::atomic<unsigned int> readptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/befa5b65_10b9e525 PS3, Line 144: std::atomic<unsigned int> readptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d53fa5fb_5ae9c976 PS3, Line 145: std::atomic<unsigned int> writeptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0e17028e_5093dd33 PS3, Line 145: std::atomic<unsigned int> writeptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2b144b74_b26dcd8c PS3, Line 145: std::atomic<unsigned int> writeptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cbe724ea_51cb83c5 PS3, Line 149: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/88740775_d51ad6f3 PS3, Line 150: using base_t = T<block_read, block_write>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/122ee559_75d81dc3 PS3, Line 150: using base_t = T<block_read, block_write>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cf8199de_635cc276 PS3, Line 152: explicit spsc() : readptr(0), writeptr(0) Bad function definition - explicit spsc() should probably be explicit spsc(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d750a72a_e552cb37 PS3, Line 163: bool spsc_push(const ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d4403e7_44baed4e PS3, Line 170: base_t::spsc_check_w(); /* blocks, ensures next (!) call succeeds */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b1eeda1c_9766fcc4 PS3, Line 176: base_t::spsc_notify_r(); /* fine after release */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9d497c6e_04e82351 PS3, Line 183: bool spsc_pop(ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d3a33b7_d038e2d9 PS3, Line 195: base_t::spsc_notify_w(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/016e3712_a9710798 PS3, Line 202: ssize_t spsc_prep_pop() Bad function definition - ssize_t spsc_prep_pop() should probably be ssize_t spsc_prep_pop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8bb90ecc_3d5ee3cb PS3, Line 202: ssize_t spsc_prep_pop() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e62776c7_99781c02 PS3, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/91490d62_ca30fa0a PS3, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3729b56a_cda98f39 PS3, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/630dc86d_23edd8d6 PS3, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/901693b1_ed64a3a1 PS3, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/59c30d55_22caf92b PS3, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d0076a18_57aa73d3 PS3, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; adding a line without newline at end of file Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a5f23dae_187a71de PS3, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3b74d98_0b7de752 PS3, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '>' (ctx:VxW) File Transceiver52M/ms/logging.cpp: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/292183b6_e8f5f6ad PS3, Line 83: .enabled = 0, trailing whitespace File Transceiver52M/ms/ms.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/def84da7_5f05856e PS3, Line 34: #define BASET blade_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/974f1c41_d35cc072 PS3, Line 34: #define BASET blade_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f59ab076_431b6db1 PS3, Line 37: #define BASET uhd_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35ead75f_37b48e3b PS3, Line 37: #define BASET uhd_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f70a63c3_5c396af4 PS3, Line 40: #define BASET ipc_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d1ef85f0_ebcda613 PS3, Line 40: #define BASET ipc_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/881a1726_0a2d9da3 PS3, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ccdd3bcd_642b4295 PS3, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7bed1ad5_af09eb8f PS3, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8e6dd14c_27cd1583 PS3, Line 60: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/522d36dd_c053b192 PS3, Line 60: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5378f472_67925f82 PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ca8ce5a_58a5e74e PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a148bfa6_02c2b616 PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ea11c0ca_92ba2446 PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b2d6da55_95291b70 PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ee1edf5_346bc3ad PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/203596a9_442c5ed1 PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd25bb29_378ff782 PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78f02691_f82ed62c PS3, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fbca279d_e7f89242 PS3, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/becc925c_5a0c8ba6 PS3, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c88d7811_dd9ef5dc PS3, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2b91cf46_5ad22f46 PS3, Line 75: GSM::Time gsmts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ddc2b7bf_61038c45 PS3, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/03b32806_ddc649f4 PS3, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bfb83da9_60bc59f7 PS3, Line 87: std::ostream null_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f49cebff_7cb2fc14 PS3, Line 89: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ae44a51_3d3d520e PS3, Line 90: dummylog() : null_stream(this){}; space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ef0d20c2_8e1f2044 PS3, Line 92: std::ostream &operator()() need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a1a031d2_e6e3dde4 PS3, Line 92: std::ostream &operator()() labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/98104e1c_59eab598 PS3, Line 104: GSM::Time global_time_keeper; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/92d58ab7_d385fbd8 PS3, Line 106: std::mutex m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0e56a1a3_f1cd1eba PS3, Line 108: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b4aaa0b_ac8daee6 PS3, Line 113: void set(GSM::Time t, int64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9fd2791f_a0138377 PS3, Line 115: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c7ef1500_9f3403a3 PS3, Line 115: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/479a4e99_77e14e32 PS3, Line 115: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/415a31af_399b900b PS3, Line 119: void inc_both() Bad function definition - void inc_both() should probably be void inc_both(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b29dbcbc_37d4f1f9 PS3, Line 119: void inc_both() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a9b6cba7_cb624fbd PS3, Line 121: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eee747c1_88976980 PS3, Line 121: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/73363a15_79b99341 PS3, Line 121: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6019d3cd_11daceec PS3, Line 125: void inc_and_update(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35a1a464_83151c80 PS3, Line 127: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71d1029a_de5380f3 PS3, Line 127: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3a84c970_01dc5e05 PS3, Line 127: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0b9b8900_ab1a2a75 PS3, Line 132: void inc_and_update_safe(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1c331074_6f3ecf89 PS3, Line 134: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fba5ebc_35ed12c9 PS3, Line 134: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/751517b4_e093f141 PS3, Line 134: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/413dc058_14c3beae PS3, Line 142: void dec_by_one() Bad function definition - void dec_by_one() should probably be void dec_by_one(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/100a0551_6d50d4b9 PS3, Line 142: void dec_by_one() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/df41448a_193b2d68 PS3, Line 144: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/be070ad4_c1ecb94d PS3, Line 144: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/61f41ecf_c11a9d17 PS3, Line 144: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e2635164_bde694bd PS3, Line 148: auto get_ts() Bad function definition - auto get_ts() should probably be auto get_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31cee22a_797e5ae5 PS3, Line 148: auto get_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8936b739_40ece684 PS3, Line 150: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba220657_76f5dde9 PS3, Line 150: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/37ca4dd4_7c46c952 PS3, Line 150: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0173f6f8_c6d1f491 PS3, Line 153: auto gsmtime() Bad function definition - auto gsmtime() should probably be auto gsmtime(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c98ae15b_8b16b147 PS3, Line 153: auto gsmtime() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e963e5dc_f60732e2 PS3, Line 155: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4a4e12f8_598a047c PS3, Line 155: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f0f83fc_285cb21d PS3, Line 155: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/757d5cfb_f6e29b94 PS3, Line 158: void get_both(GSM::Time *t, int64_t *ts) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6faf43fa_90157638 PS3, Line 158: void get_both(GSM::Time *t, int64_t *ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/220b2e39_292584d5 PS3, Line 160: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4dd9f888_7282f6c1 PS3, Line 160: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/68b93fbf_ec0f1a24 PS3, Line 160: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d6763e05_0932e1c0 PS3, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/28c5d133_674e839c PS3, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78c518fd_63734e76 PS3, Line 176: std::thread rx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1957d217_f0afc88c PS3, Line 177: std::thread tx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/83e7ffc5_027f9875 PS3, Line 178: std::thread *calcrval_task; need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ee9850b8_f7ba7d51 PS3, Line 178: std::thread *calcrval_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/880df032_6e41dbb1 PS3, Line 189: std::atomic<bool> rcv_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/503e01bb_4de997be PS3, Line 189: std::atomic<bool> rcv_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f047c94b_30cf9ae1 PS3, Line 189: std::atomic<bool> rcv_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ce18034b_82b910b6 PS3, Line 190: std::atomic<bool> sch_thread_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9da56b4_7cc36a77 PS3, Line 190: std::atomic<bool> sch_thread_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bbb3661d_64439466 PS3, Line 190: std::atomic<bool> sch_thread_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b8189c25_9a7de424 PS3, Line 197: void start(); Bad function definition - void start() should probably be void start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/98f0fcc5_ec3c0fdf PS3, Line 198: std::atomic<bool> upper_is_ready; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9767233_824d76f2 PS3, Line 198: std::atomic<bool> upper_is_ready; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/50b3cb49_2fe63ddb PS3, Line 198: std::atomic<bool> upper_is_ready; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/057d4741_38cd68a6 PS3, Line 201: bool handle_sch_or_nb(); Bad function definition - bool handle_sch_or_nb() should probably be bool handle_sch_or_nb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6fa91560_d5392a55 PS3, Line 207: int init_device(); Bad function definition - int init_device() should probably be int init_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0c31b0de_6d6cdee6 PS3, Line 208: int init_dev_and_streams(); Bad function definition - int init_dev_and_streams() should probably be int init_dev_and_streams(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/34c1c93c_72d737ab PS3, Line 209: void stop_threads(); Bad function definition - void stop_threads() should probably be void stop_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/80c2182a_00cf7053 PS3, Line 211: void *tx_cb(); Bad function definition - void *tx_cb() should probably be void *tx_cb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/819f9785_68de1ebb PS3, Line 212: void maybe_update_gain(one_burst &brst); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4a4c4c7f_a02d11bb PS3, Line 225: bh_fn_t rx_bh(); Bad function definition - bh_fn_t rx_bh() should probably be bh_fn_t rx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a0729f2_13db89e0 PS3, Line 226: bh_fn_t tx_bh(); Bad function definition - bh_fn_t tx_bh() should probably be bh_fn_t tx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/835e6a73_7a248542 PS3, Line 229: void set_ta(int val) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/66a6ab17_23a8770f PS3, Line 235: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f4af43cd_7d4f91c2 PS3, Line 240: void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype, open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/adab125f_be6623f8 PS3, Line 252: std::cerr << name << " affinity: errreur! " << std::strerror(errno); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32e33cdb_cfccdb54 PS3, Line 260: std::cerr << name << " sched: errreur! " << std::strerror(errno); labels should not be indented File Transceiver52M/ms/ms_rx_burst.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f140d94_984a9526 PS3, Line 25: void rcv_bursts_test(rx_queue_t *q, unsigned int *tsc, int scale); adding a line without newline at end of file File Transceiver52M/ms/ms_upper.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e3740eb6_24ce1e63 PS3, Line 44: bool driveControl(); Bad function definition - bool driveControl() should probably be bool driveControl(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eb2822ee_9538b166 PS3, Line 45: void driveReceiveFIFO(); Bad function definition - void driveReceiveFIFO() should probably be void driveReceiveFIFO(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d477f08f_64ac9533 PS3, Line 46: void driveTx(); Bad function definition - void driveTx() should probably be void driveTx(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6b3b2180_4e57e97d PS3, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76ab6e59_15abdc8c PS3, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5f808a82_9c774059 PS3, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/21d4ef33_2b28d9ae PS3, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/34d1d772_ade734de PS3, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9fb048a_568f398d PS3, Line 50: std::thread thr_control, thr_rx, thr_tx; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b208705b_6d8d8dc5 PS3, Line 52: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f67c2fd_bcae3013 PS3, Line 53: void start_threads(); Bad function definition - void start_threads() should probably be void start_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/28faa287_c4bb8ef2 PS3, Line 54: void start_lower_ms(); Bad function definition - void start_lower_ms() should probably be void start_lower_ms(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8b9766e_e2536a58 PS3, Line 56: upper_trx(){}; space required before the open brace '{' File Transceiver52M/ms/sch.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/21b7825c_88b2206f PS3, Line 130: int gsm_fcch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c4cf00c0_373b7d93 PS3, Line 134: int gsm_sch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/668f8388_fb4863d8 PS3, Line 205: #if 1 Consider removing the #if 1 and its #endif Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3ea69fe2_12e201d4 PS3, Line 210: float a, b, c, d, ang, avg = 0.0f; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f86444f4_f3f92a2e PS3, Line 235: ang = b - a; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1cb901d8_451f40da PS3, Line 237: if (ang > M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4b9622ad_cfd6f7f0 PS3, Line 238: ang -= 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/96c5b166_22212a38 PS3, Line 239: else if (ang < -M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dbd5e655_538499fb PS3, Line 240: ang += 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e61359f3_209372ee PS3, Line 242: avg += ang; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fec44201_f9c122ba PS3, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b76eab7f_f9434c11 PS3, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4ff3e00c_d85118c0 PS3, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c98a68c6_05f3ece8 PS3, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/052a04cc_a7cde47f PS3, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d38a68dc_b2ee1b0e PS3, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35976b64_6d39afcd PS3, Line 314: static __attribute__((constructor)) void init() Bad function definition - void init() should probably be void init(void) File Transceiver52M/ms/uhd_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/88b0cf87_62584e99 PS3, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bcb6f7f5_6b24c3a6 PS3, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4c52a074_943ac956 PS3, Line 41: uhd::rx_metadata_t *md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6b6dfc13_75069efd PS3, Line 43: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/318d8ee7_5a74b8ca PS3, Line 43: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7c70d1e4_dce6868c PS3, Line 47: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d03a74a_9fccc848 PS3, Line 47: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c57063f9_79333734 PS3, Line 51: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19a67292_7243580b PS3, Line 56: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3f1695fc_000bb28c PS3, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c8a27374_40c31769 PS3, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f7486b23_42b54dbe PS3, Line 69: template <typename T> struct uhd_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f66f54a1_e47caa1e PS3, Line 69: template <typename T> struct uhd_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/36edfbd0_996103fa PS3, Line 70: uhd::usrp::multi_usrp::sptr dev; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/60d5f432_b6706ee7 PS3, Line 71: uhd::rx_streamer::sptr rx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ff8ba3a9_87a4d4e4 PS3, Line 72: uhd::tx_streamer::sptr tx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/06f46b9b_f5c791c4 PS3, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76f956cb_4536441d PS3, Line 74: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/847fff0d_ddab50e9 PS3, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71310bcc_3b397a9e PS3, Line 74: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/26bb493f_919cafc9 PS3, Line 90: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58d07258_13d09f46 PS3, Line 90: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/40901927_d80296a6 PS3, Line 95: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31a4d114_f4da6b00 PS3, Line 102: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c3e18785_6bab3abd PS3, Line 109: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0adc7b29_8921f047 PS3, Line 114: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19be2193_a29cc58d PS3, Line 122: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9e53d965_7515a6d3 PS3, Line 130: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/55dc7dce_0048da9f PS3, Line 135: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/249bc39a_8c59dc3d PS3, Line 145: std::string args = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b6a97b95_fe46214b PS3, Line 148: std::cout << "Using Device: " << dev->get_pp_string() << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86cde646_62b5aaef PS3, Line 153: uhd::tune_request_t tune_request(freq, 0); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/72dc2a0d_d005d898 PS3, Line 162: std::this_thread::sleep_for(std::chrono::milliseconds(lock_delay_ms)); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9deb4645_4b368ac8 PS3, Line 164: uhd::stream_args_t stream_args("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9c97274e_a9933aa4 PS3, Line 166: uhd::stream_args_t stream_args2("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d1edce7_07c3abcc PS3, Line 177: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7916fb56_3f968e8b PS3, Line 182: uhd::rx_metadata_t md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d796734_289225cc PS3, Line 186: std::cerr << boost::format("Timeout while streaming") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bd6a3e4_4ec7755f PS3, Line 190: std::cerr << boost::format("Got an overflow indication\n") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e52c55be_c3a46247 PS3, Line 194: std::cerr << str(boost::format("Receiver error: %s") % md.strerror()); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7222a21d_a1f0578c PS3, Line 209: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/398ab124_d6b5fed7 PS3, Line 211: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6a27e87_aa3eb4c3 PS3, Line 214: uhd::stream_cmd_t stream_cmd(uhd::stream_cmd_t::STREAM_MODE_START_CONTINUOUS); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b68f1cfe_698ba958 PS3, Line 225: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7066c193_84905e34 PS3, Line 227: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d56dca20_6c37339d PS3, Line 232: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71fafa62_5d1064bc PS3, Line 234: uhd::tx_metadata_t m = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4cfc7dbd_76814509 PS3, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/df19065b_07710025 PS3, Line 239: std::vector<void *> ptrs(1, buffer); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/399f02af_cc39508d PS3, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3ccccf9_9d527358 PS3, Line 239: std::vector<void *> ptrs(1, buffer); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d71ce1b_4cfd38d4 PS3, Line 243: uhd::async_metadata_t async_md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3eb52d04_53904dcd PS3, Line 248: std::cout << (tx_ack ? "yay" : "nay") << " " << async_md.time_spec.to_ticks(rxticks) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6b75c43_b3568ea6 PS3, Line 251: }; adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Comment-Date: Thu, 01 Dec 2022 11:38:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment