Attention is currently required from: Hoernchen.

Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email )

Change subject: add fw update crcstub ......................................................................

Patch Set 6:

(9 comments)

File crc_code.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/51af20d7_2e6ac36d... : PS6, Line 36: for (uint32_t i = 0; i < length; i++) { suspect code indent for conditional statements (2, 4)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/7a68d3ea_cf214730... : PS6, Line 38: for (uint8_t j = 0; j < 8; j++) { suspect code indent for conditional statements (4, 6)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/9aaf83a3_dda7d8ae... : PS6, Line 63: if (calculated_crc != expected_crc) { suspect code indent for conditional statements (2, 4)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/cf766053_f61dc46c... : PS6, Line 79: while (1) suspect code indent for conditional statements (2, 4)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/981383f2_744ed92c... : PS6, Line 92: if (argc != 4) { suspect code indent for conditional statements (2, 4)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/7e8cabbf_14618b21... : PS6, Line 104: if (!f) { suspect code indent for conditional statements (2, 4)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/97fd2ceb_c1acf5fd... : PS6, Line 110: if (fseek(f, (long)start_offset, SEEK_SET) != 0) { suspect code indent for conditional statements (2, 4)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/adf5f90e_4f713cf9... : PS6, Line 117: if (!buf) { suspect code indent for conditional statements (2, 4)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/6012fab3_84e50789... : PS6, Line 126: if (read_bytes != length) { suspect code indent for conditional statements (2, 4)