Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email ) Change subject: add fw update crcstub ...................................................................... Patch Set 6: (9 comments) File crc_code.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/51af20d7_2e6ac36… : PS6, Line 36: for (uint32_t i = 0; i < length; i++) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/7a68d3ea_cf21473… : PS6, Line 38: for (uint8_t j = 0; j < 8; j++) { suspect code indent for conditional statements (4, 6) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/9aaf83a3_dda7d8a… : PS6, Line 63: if (calculated_crc != expected_crc) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/cf766053_f61dc46… : PS6, Line 79: while (1) suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/981383f2_744ed92… : PS6, Line 92: if (argc != 4) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/7e8cabbf_14618b2… : PS6, Line 104: if (!f) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/97fd2ceb_c1acf5f… : PS6, Line 110: if (fseek(f, (long)start_offset, SEEK_SET) != 0) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/adf5f90e_4f713cf… : PS6, Line 117: if (!buf) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/6012fab3_84e5078… : PS6, Line 126: if (read_bytes != length) { suspect code indent for conditional statements (2, 4) -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I39eae7aaafd5531db6ce48837c9499432caadbed Gerrit-Change-Number: 39437 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Comment-Date: Wed, 29 Jan 2025 19:22:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No