Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 1: (408 comments) File Transceiver52M/ms/bladerf_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/301ce7d7_7ed6cfc8 PS1, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/08a8afc4_5b2ba3a8 PS1, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/16f36076_513dd188 PS1, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/01bea4ec_7230dc08 PS1, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e675d0e6_9718d66d PS1, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e5faf79a_84304375 PS1, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2d908d42_6f5f60e4 PS1, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78a8f0f8_8acb2a5c PS1, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/154531ec_43bf2cde PS1, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/01981329_f3ce9af4 PS1, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9bdb9cf7_821efbf4 PS1, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d62cfb92_211c1bd5 PS1, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b8bdcb9_52667f40 PS1, Line 52: template <class R, class... Args> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8c4edfe7_52cefc12 PS1, Line 52: template <class R, class... Args> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5fe1db58_e9836067 PS1, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6318e05a_3dfef53f PS1, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bf6dd794_9c27d17a PS1, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d9721a3_6e2ef504 PS1, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6056e394_536aaf0d PS1, Line 57: if (rval != 0) { suspect code indent for conditional statements (8, 26) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c962abe7_b164aa10 PS1, Line 58: std::cerr << ((rval >= 0) ? "OK:" : bladerf_strerror(rval)) << ':' << finame << ':' << line << ':' labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ece88b78_e0e5d340 PS1, Line 66: #define blade_check(func, ...) exec_and_check(func, #func, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__) __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c28afd41_2c4456c7 PS1, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f06d08e5_93a83bba PS1, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/63189dea_e3d1bf5d PS1, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6bb5aadd_f6b619ce PS1, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bf012ab9_6309c48e PS1, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/22a249c9_50bd86e8 PS1, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02cd1b21_7fbb7b12 PS1, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8ab72df_407feeac PS1, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1ee1ccdf_2b1f1909 PS1, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/939af6a4_2bd3faf0 PS1, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d1567216_e6f68775 PS1, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f6105ea_616e26f6 PS1, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/964463cd_bc433ceb PS1, Line 83: int actual_samples_per_msg() Bad function definition - int actual_samples_per_msg() should probably be int actual_samples_per_msg(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3efd1c5f_b4984842 PS1, Line 83: int actual_samples_per_msg() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1d8120ba_fd063611 PS1, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/82e0e1de_488c5df7 PS1, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6008f4ec_00c212c4 PS1, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fd6c900_8504f04f PS1, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78132836_ee953dfb PS1, Line 87: int actual_samples_per_buffer() Bad function definition - int actual_samples_per_buffer() should probably be int actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/051277aa_a37eb15d PS1, Line 87: int actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/01769f58_01a1e64d PS1, Line 91: int samples_per_buffer() Bad function definition - int samples_per_buffer() should probably be int samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/efaef42d_2999ba4f PS1, Line 91: int samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a0db27b_e000b09e PS1, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b7b58e8a_e317eef3 PS1, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/81a562ef_ef4b8e0d PS1, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/28c9fe46_6c129f82 PS1, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/53cb9e14_51e8a58d PS1, Line 95: int num_msgs_per_buffer() Bad function definition - int num_msgs_per_buffer() should probably be int num_msgs_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/36b12ae6_46146924 PS1, Line 95: int num_msgs_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3f1ee94_8bcc0572 PS1, Line 99: auto get_first_ts() Bad function definition - auto get_first_ts() should probably be auto get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/85ca58f5_9d382110 PS1, Line 99: auto get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d2a2315b_47c10ed6 PS1, Line 103: constexpr auto *getsampleoffset(int ofs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2314ebc0_685e4e43 PS1, Line 109: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b32c82b2_39ed8ae0 PS1, Line 118: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99edde0b_8692f8c3 PS1, Line 156: int write_n_burst(blade_sample_type *in, int num, uint64_t first_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1166ba10_a7a7409a PS1, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31e3b4c4_f1eabc7a PS1, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f40f8255_59b4032c PS1, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cb22ab73_89802fee PS1, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9baee26d_ccd18a3a PS1, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/80dc2994_8f4c8263 PS1, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c8de2500_2077d78b PS1, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0a799672_df328cf9 PS1, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/59f92ec7_5e6e79da PS1, Line 185: template <typename T> struct blade_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e6d41f75_7ec4f481 PS1, Line 185: template <typename T> struct blade_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ab4a0d97_0588984c PS1, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c8110999_33b766d0 PS1, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/195b14fa_d79e36d2 PS1, Line 202: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9773256d_6a1e9558 PS1, Line 223: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2e75d2bb_3626816b PS1, Line 223: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/05f36874_985c3bd0 PS1, Line 242: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6aa3c78e_119ba458 PS1, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/573e0a61_ba791209 PS1, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b2d90d2e_d49ff7bf PS1, Line 250: std::cerr << "open failed, device missing?" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71208f5e_a2f62333 PS1, Line 254: std::cerr << "open failed, only superspeed (usb3) supported!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f377375_694adc76 PS1, Line 271: std::cerr << "unable to lock refclk!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f089d25_ec2a22df PS1, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f287a6d_69d65a2a PS1, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/09dbe486_e5c9f1e3 PS1, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e8ca0784_f15328d8 PS1, Line 316: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a991272f_7f9c64fb PS1, Line 318: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9053bb89_aac2f11d PS1, Line 320: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b4de598a_3094df6a PS1, Line 323: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dcc4ecf9_a88fde9c PS1, Line 325: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/14cd08b2_8411d9cb PS1, Line 327: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76303387_3fcf4894 PS1, Line 330: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/149efb8c_a7d66365 PS1, Line 335: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d4ebe99d_7f028b9f PS1, Line 338: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6eb53714_f95a6f41 PS1, Line 340: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cbdd29d5_2025ad77 PS1, Line 343: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3dd9e8a7_b78dadb8 PS1, Line 346: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd5d26d4_3b495644 PS1, Line 348: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/521602c2_c630e488 PS1, Line 351: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f6ae613_ab4da7df PS1, Line 356: static void check_timestamp(dev_buf_t *rcd) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/30b84aeb_5cda4ea7 PS1, Line 363: } else if (last_ts + rcd->actual_samples_per_buffer() != rcd->m[0].ts) { suspect code indent for conditional statements (16, 34) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/174ad80b_de954a6a PS1, Line 364: std::cerr << "RX Overrun!" << last_ts << " " << rcd->actual_samples_per_buffer() << " " labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a20ad618_fa1c6192 PS1, Line 372: bladerf_stream_cb getrxcb(bh_fn_t rxbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/20b1d771_b671fdd8 PS1, Line 376: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f54cab92_218d1e0b PS1, Line 377: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58ee0d83_a0ca2729 PS1, Line 392: bladerf_stream_cb gettxcb(bh_fn_t txbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9ecf1219_d61b1067 PS1, Line 396: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3c379c0_45f13802 PS1, Line 397: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e310768_126066e9 PS1, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bda9e2f_b43cef6b PS1, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/47ca03f3_efc013a3 PS1, Line 408: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1567cc5e_7c6f90b5 PS1, Line 410: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/63aab3aa_eb97a5b4 PS1, Line 414: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aa56d10f_03ae9cf5 PS1, Line 420: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/545e5612_aaf912c3 PS1, Line 422: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/08fd9bc4_2fb9d25a PS1, Line 426: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/25cb3aa6_d6683eb8 PS1, Line 433: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/14fac554_de2c2187 PS1, Line 435: //get empty bufer from list 'bufer' may be misspelled - perhaps 'buffer'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9db1e49a_ea6fe9d4 PS1, Line 436: tx_buf_q_type::elem_t rcd; labels should not be indented File Transceiver52M/ms/ipc_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c54bbdf6_d4cdeb06 PS1, Line 38: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/daf18400_2bed079c PS1, Line 38: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e22466e9_0769f938 PS1, Line 45: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e54dab24_2d28d3db PS1, Line 45: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0afc2910_b9eab8c8 PS1, Line 49: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/466329d2_bafb9e77 PS1, Line 49: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/56feb6f9_d962ea9a PS1, Line 53: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f23088c8_f7a8757a PS1, Line 58: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4b7e6417_609ce6e0 PS1, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/db770060_9d26b5d4 PS1, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/691248ab_6fe4bddd PS1, Line 71: template <typename T> struct ipc_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/44b9787b_5bbce496 PS1, Line 71: template <typename T> struct ipc_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/80aa389c_e1406a4f PS1, Line 76: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d6a19bcc_3e60def3 PS1, Line 76: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/37d938aa_aa1898b3 PS1, Line 76: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eb7b1257_2acce708 PS1, Line 76: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c75148b7_56fa1bd2 PS1, Line 92: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ffa89cb7_f7f058b4 PS1, Line 99: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7d55c422_a3be8e50 PS1, Line 106: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f39a0a03_78f9706f PS1, Line 111: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2fd44612_70f63f64 PS1, Line 119: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9315089b_76fd5027 PS1, Line 127: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5a6e065d_07da1742 PS1, Line 132: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f9b607a_f3f9f282 PS1, Line 137: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1d17e052_5c95c31e PS1, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/75764492_cbd4b50d PS1, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3d69e3c_2e5f84d1 PS1, Line 164: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1a19c76a_be13c44b PS1, Line 166: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d6b9df0_58f5c06a PS1, Line 175: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eb923f6b_6e18e1ea PS1, Line 177: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/05c7bf4e_5ef5ea00 PS1, Line 183: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86894aa3_698fbb39 PS1, Line 188: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5a39540d_7992d228 PS1, Line 193: void signal_start() Bad function definition - void signal_start() should probably be void signal_start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/beab08b0_65c5e97e PS1, Line 193: void signal_start() open brace '{' following function definitions go on the next line File Transceiver52M/ms/itrq.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a40b1748_e9aeafb8 PS1, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cf58fb03_4671cd1d PS1, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/efb5b464_6d81a601 PS1, Line 52: std::condition_variable cond_r, cond_w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b9af9f8_b6615fe6 PS1, Line 53: std::mutex lr, lw; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/63ace79c_56b17246 PS1, Line 54: std::atomic_int r_flag, w_flag; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/192ee704_54eb2b0e PS1, Line 56: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d51d3ccf_1d47342d PS1, Line 57: explicit spsc_cond_detail() : r_flag(0), w_flag(0) Bad function definition - explicit spsc_cond_detail() should probably be explicit spsc_cond_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7e52fe76_801f2d65 PS1, Line 65: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/472302d0_59b7a8b0 PS1, Line 65: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f0d76b57_36c4a98d PS1, Line 67: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e7e365ea_635201f2 PS1, Line 67: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc0265fd_3dd08d08 PS1, Line 67: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ecc82fbe_a0eb1403 PS1, Line 73: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/25c38939_4f8c7beb PS1, Line 73: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18e8412b_e65d2f31 PS1, Line 75: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8616ff9f_553740c9 PS1, Line 75: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb8f3d1c_03c86f0e PS1, Line 75: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3c89dac6_b2c1ca27 PS1, Line 81: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9aaba957_d3160e5f PS1, Line 81: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7795df8_16d48f24 PS1, Line 83: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a3786239_1f8f5e35 PS1, Line 83: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b57715ee_68fbdb6a PS1, Line 83: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1c47424_1ff2e83d PS1, Line 87: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e81bdba3_6f2be5fa PS1, Line 87: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8dc3426a_275a3870 PS1, Line 89: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78ed56bb_2cf51434 PS1, Line 89: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e3459026_207c06ac PS1, Line 89: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/abc3dabb_9fbc75ea PS1, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/05284692_ea8ea07f PS1, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e79ca070_8187c70f PS1, Line 99: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/597f2530_557ca964 PS1, Line 100: explicit spsc_efd_detail() Bad function definition - explicit spsc_efd_detail() should probably be explicit spsc_efd_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e1498c20_ad3e294f PS1, Line 111: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9be71eb_027f43b3 PS1, Line 111: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32796c89_19706f34 PS1, Line 116: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3d8a04bd_b4735503 PS1, Line 116: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2e766b06_09664752 PS1, Line 121: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/634adde1_8f337d61 PS1, Line 121: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/47a6e82e_5e696a25 PS1, Line 126: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cfb5eeba_28410b4e PS1, Line 126: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f435ccf3_c56467fc PS1, Line 131: int get_r_efd() Bad function definition - int get_r_efd() should probably be int get_r_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9249a9c_5ddc9c44 PS1, Line 131: int get_r_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c48de86e_dbe7f5bf PS1, Line 135: int get_w_efd() Bad function definition - int get_w_efd() should probably be int get_w_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6c8c731e_05308e1d PS1, Line 135: int get_w_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9721164e_d5ed5b39 PS1, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/079a3f73_233d02bf PS1, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/28806554_53dcc5ba PS1, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/702271f9_353206e8 PS1, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e7aaa8c5_73b12601 PS1, Line 142: class spsc : public T<block_read, block_write> { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99493986_53707b94 PS1, Line 142: class spsc : public T<block_read, block_write> { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e120f5e1_1f726d8d PS1, Line 144: std::atomic<unsigned int> readptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d34b077d_291a6d7b PS1, Line 144: std::atomic<unsigned int> readptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f5961918_7982c4e4 PS1, Line 144: std::atomic<unsigned int> readptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7dd54bef_600af7ac PS1, Line 145: std::atomic<unsigned int> writeptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7d0b0481_9a8c641e PS1, Line 145: std::atomic<unsigned int> writeptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc79892b_c5365fac PS1, Line 145: std::atomic<unsigned int> writeptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5c535969_2ec0d346 PS1, Line 149: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/16e8844f_8e97353c PS1, Line 150: using base_t = T<block_read, block_write>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fe2bc7d_0f9e003a PS1, Line 150: using base_t = T<block_read, block_write>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/305ce30f_8f70a680 PS1, Line 152: explicit spsc() : readptr(0), writeptr(0) Bad function definition - explicit spsc() should probably be explicit spsc(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/56737532_d05bfc8a PS1, Line 163: bool spsc_push(const ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d6b04f7_469b17b9 PS1, Line 170: base_t::spsc_check_w(); /* blocks, ensures next (!) call succeeds */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b83b97ee_892c276f PS1, Line 176: base_t::spsc_notify_r(); /* fine after release */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71f9b123_cbbecd2a PS1, Line 183: bool spsc_pop(ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9b80b366_e2b56d3f PS1, Line 195: base_t::spsc_notify_w(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3043ddd_dc9801a1 PS1, Line 202: ssize_t spsc_prep_pop() Bad function definition - ssize_t spsc_prep_pop() should probably be ssize_t spsc_prep_pop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f4299147_3f6cba0e PS1, Line 202: ssize_t spsc_prep_pop() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3454dde2_151969dc PS1, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c08a57a9_61392d71 PS1, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4993ba93_f02177fd PS1, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fdbbd050_9a1c24e5 PS1, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/15a8fb04_4e3bd526 PS1, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5fc6db9c_1a0aa9b9 PS1, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4cde2496_56afe477 PS1, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; adding a line without newline at end of file Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35b6ce23_e973a6df PS1, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78d7f45f_56d9f026 PS1, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '>' (ctx:VxW) File Transceiver52M/ms/logging.cpp: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58c0929e_df0ee555 PS1, Line 83: .enabled = 0, trailing whitespace File Transceiver52M/ms/ms.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d65ecbf8_d8376c7b PS1, Line 34: #define BASET blade_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d39d9f27_d057b972 PS1, Line 34: #define BASET blade_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/41a86583_973a21ae PS1, Line 37: #define BASET uhd_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e72dde31_db26f166 PS1, Line 37: #define BASET uhd_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/df6b1bde_2c32d5d6 PS1, Line 40: #define BASET ipc_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d139ca74_0208ec25 PS1, Line 40: #define BASET ipc_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ec87ccbe_9a214938 PS1, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dfcc88f7_a74109cc PS1, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f34dfc8_cb6137b8 PS1, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/935c1713_b3ab6a52 PS1, Line 60: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79e68de3_a992c7ea PS1, Line 60: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dd3e5b7a_54045c3f PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b8394694_12b06794 PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d076a1d5_d1529c37 PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aae9ce48_d916d378 PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6499b796_7a43c2dd PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d21e3e47_71098a72 PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c88434a5_56af990a PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18da3d8b_d478c0fd PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/44e72462_eca7d6ef PS1, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f501fa47_666e4273 PS1, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/64d83cde_dd7b4229 PS1, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fc376c22_743b138a PS1, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/215d7852_373306e5 PS1, Line 75: GSM::Time gsmts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ff77589_9618d4c7 PS1, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8be4f8d_0ca85f71 PS1, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/04a95bba_e4d28e0a PS1, Line 87: std::ostream null_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/27aff2c7_d975e140 PS1, Line 89: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3a9d17a6_5942e9e5 PS1, Line 90: dummylog() : null_stream(this){}; space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a49bd9f9_d80107e8 PS1, Line 92: std::ostream &operator()() need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19fdc277_761b7e19 PS1, Line 92: std::ostream &operator()() labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ceac5ba1_4c895bfd PS1, Line 104: GSM::Time global_time_keeper; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/03e2889e_9e2d54d2 PS1, Line 106: std::mutex m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9a60dd8_b04b4a44 PS1, Line 108: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0a7bc769_ef60a158 PS1, Line 113: void set(GSM::Time t, int64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/873483ae_dccf9053 PS1, Line 115: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b69d80a4_978c49f8 PS1, Line 115: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/87c52991_b77df29b PS1, Line 115: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4b137272_6db2b612 PS1, Line 119: void inc_both() Bad function definition - void inc_both() should probably be void inc_both(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/454a7caf_5da9472c PS1, Line 119: void inc_both() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/efc9b098_7bb34677 PS1, Line 121: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/42c29045_751d8254 PS1, Line 121: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e655276f_b4fa02f6 PS1, Line 121: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fcf9df63_1ebf32e9 PS1, Line 125: void inc_and_update(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5e18186c_a4619166 PS1, Line 127: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f94053bf_7d33d025 PS1, Line 127: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7799adbd_b1473cfd PS1, Line 127: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/48375d69_29d5e966 PS1, Line 132: void inc_and_update_safe(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/82d3b2c2_acd4f8b2 PS1, Line 134: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b9a470c6_3ed35c52 PS1, Line 134: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e116a931_c5dad632 PS1, Line 134: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/083ebfa3_43edb5f3 PS1, Line 142: void dec_by_one() Bad function definition - void dec_by_one() should probably be void dec_by_one(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/44f97cd9_9b3a3442 PS1, Line 142: void dec_by_one() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86c34a2a_4d61a9eb PS1, Line 144: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c05abb3e_af917fb5 PS1, Line 144: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8046fd7_16ea16ee PS1, Line 144: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/584e27f5_35d7917c PS1, Line 148: auto get_ts() Bad function definition - auto get_ts() should probably be auto get_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4853b4c9_c236d8ae PS1, Line 148: auto get_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/767ee6a6_b921d194 PS1, Line 150: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e43f29ce_da3ead7c PS1, Line 150: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/370bb821_67accdcf PS1, Line 150: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/94073af6_8d8236fa PS1, Line 153: auto gsmtime() Bad function definition - auto gsmtime() should probably be auto gsmtime(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1101986_18019820 PS1, Line 153: auto gsmtime() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/12a8413c_7ffbfbb2 PS1, Line 155: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/60621d30_673401e6 PS1, Line 155: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f3eb5ac7_e6140418 PS1, Line 155: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/499d4927_9d705bdb PS1, Line 158: void get_both(GSM::Time *t, int64_t *ts) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3de5e2b6_ec4766e3 PS1, Line 158: void get_both(GSM::Time *t, int64_t *ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b375110_6df9083f PS1, Line 160: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9e3760e1_ae2f7b53 PS1, Line 160: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/82255939_8eb3d8e8 PS1, Line 160: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/80c6c57b_cf59499b PS1, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f541de2_fadc0f76 PS1, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f031d52_44e76319 PS1, Line 176: std::thread rx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/616999b9_7d2882b0 PS1, Line 177: std::thread tx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9cbd69a0_75cd13e3 PS1, Line 178: std::thread *calcrval_task; need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5504c484_a550396d PS1, Line 178: std::thread *calcrval_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5c0ef1ab_c9091643 PS1, Line 189: std::atomic<bool> rcv_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f89b471_26bbc774 PS1, Line 189: std::atomic<bool> rcv_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23077ac2_968434a0 PS1, Line 189: std::atomic<bool> rcv_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/591305be_a83102aa PS1, Line 190: std::atomic<bool> sch_thread_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1dee4091_864b6e01 PS1, Line 190: std::atomic<bool> sch_thread_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1223e246_e4152e6e PS1, Line 190: std::atomic<bool> sch_thread_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/925f126b_54dfd381 PS1, Line 197: void start(); Bad function definition - void start() should probably be void start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19d6c92e_31f71adc PS1, Line 198: std::atomic<bool> upper_is_ready; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/deeb7108_8c37f669 PS1, Line 198: std::atomic<bool> upper_is_ready; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1b08c2ef_837e7a81 PS1, Line 198: std::atomic<bool> upper_is_ready; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f217aa7_b1dc2fe7 PS1, Line 201: bool handle_sch_or_nb(); Bad function definition - bool handle_sch_or_nb() should probably be bool handle_sch_or_nb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7d33626_0ed06c08 PS1, Line 207: int init_device(); Bad function definition - int init_device() should probably be int init_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/965dac1a_30824d87 PS1, Line 208: int init_dev_and_streams(); Bad function definition - int init_dev_and_streams() should probably be int init_dev_and_streams(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/67805988_665e05fa PS1, Line 209: void stop_threads(); Bad function definition - void stop_threads() should probably be void stop_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/44d50bf2_5149fa16 PS1, Line 211: void *tx_cb(); Bad function definition - void *tx_cb() should probably be void *tx_cb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/381a128c_7e83dcbb PS1, Line 212: void maybe_update_gain(one_burst &brst); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c13b9979_e8e86a4c PS1, Line 225: bh_fn_t rx_bh(); Bad function definition - bh_fn_t rx_bh() should probably be bh_fn_t rx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ad808354_f86047e5 PS1, Line 226: bh_fn_t tx_bh(); Bad function definition - bh_fn_t tx_bh() should probably be bh_fn_t tx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/60a2ad9d_c5f6d991 PS1, Line 229: void set_ta(int val) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cf418435_bbf337ae PS1, Line 235: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/83b1961e_6f811538 PS1, Line 240: void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype, open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0c5183d2_c2df9c6b PS1, Line 252: std::cerr << name << " affinity: errreur! " << std::strerror(errno); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/801d5967_6774036d PS1, Line 260: std::cerr << name << " sched: errreur! " << std::strerror(errno); labels should not be indented File Transceiver52M/ms/ms_rx_burst.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4c56c7cc_7fa218ab PS1, Line 25: void rcv_bursts_test(rx_queue_t *q, unsigned int *tsc, int scale); adding a line without newline at end of file File Transceiver52M/ms/ms_upper.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b7213c8f_edc77838 PS1, Line 44: bool driveControl(); Bad function definition - bool driveControl() should probably be bool driveControl(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f06cbdcf_c0dc974f PS1, Line 45: void driveReceiveFIFO(); Bad function definition - void driveReceiveFIFO() should probably be void driveReceiveFIFO(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3cfdc50_42432fb3 PS1, Line 46: void driveTx(); Bad function definition - void driveTx() should probably be void driveTx(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/af574952_68c5ab1a PS1, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e7e5a58d_eb955538 PS1, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a1cea60e_5d2e21b3 PS1, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/48741846_45c4d958 PS1, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/83e3fb27_0b4e5b29 PS1, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b94c85e1_52fd85bc PS1, Line 50: std::thread thr_control, thr_rx, thr_tx; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/455cb909_eabbcc02 PS1, Line 52: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e67088d9_69e1dccb PS1, Line 53: void start_threads(); Bad function definition - void start_threads() should probably be void start_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bc68e2d_7259925d PS1, Line 54: void start_lower_ms(); Bad function definition - void start_lower_ms() should probably be void start_lower_ms(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/61211e94_6dd40260 PS1, Line 56: upper_trx(){}; space required before the open brace '{' File Transceiver52M/ms/sch.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/443eed6e_9706ba60 PS1, Line 130: int gsm_fcch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/125adda5_fb3963f0 PS1, Line 134: int gsm_sch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9352bb4b_4be9805a PS1, Line 205: #if 1 Consider removing the #if 1 and its #endif Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f275701b_8fba1c0d PS1, Line 210: float a, b, c, d, ang, avg = 0.0f; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f6defda_fabd227a PS1, Line 235: ang = b - a; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5a340882_2f3bfee6 PS1, Line 237: if (ang > M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/654de55d_8ba7a168 PS1, Line 238: ang -= 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/561454a4_ae39c6ba PS1, Line 239: else if (ang < -M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11fca725_2be43cf7 PS1, Line 240: ang += 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5683fa52_0d94b7b6 PS1, Line 242: avg += ang; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6bd3bd59_6d216316 PS1, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f5610906_ac7aee74 PS1, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6ee80b5d_9239c3c2 PS1, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/732121ab_9ecc6408 PS1, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b43028c_59b07a90 PS1, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/77c0945a_25d8c39d PS1, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b8dc9e9f_7ccd5f21 PS1, Line 314: static __attribute__((constructor)) void init() Bad function definition - void init() should probably be void init(void) File Transceiver52M/ms/uhd_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d08b327a_9f8b7b2c PS1, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb2cf9c1_2ae6e05c PS1, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b26fec6_360059e4 PS1, Line 41: uhd::rx_metadata_t *md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/94cda8ec_519594ab PS1, Line 43: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/413b8ea4_d5889f9d PS1, Line 43: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5ddea827_cf4c8b35 PS1, Line 47: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/848f2347_92c71b88 PS1, Line 47: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/57ccc6fc_1d2c0ddd PS1, Line 51: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fc70be74_28c9067c PS1, Line 56: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/09971353_e75781c8 PS1, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c278d934_928a93b9 PS1, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d67521a_f2a981f0 PS1, Line 69: template <typename T> struct uhd_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/637f711c_332bbaa4 PS1, Line 69: template <typename T> struct uhd_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3261757c_e2608a3a PS1, Line 70: uhd::usrp::multi_usrp::sptr dev; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f222fdfe_04b7ab37 PS1, Line 71: uhd::rx_streamer::sptr rx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f2e0bff_55255261 PS1, Line 72: uhd::tx_streamer::sptr tx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f719c36c_eedc9d24 PS1, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c0868317_7a81547c PS1, Line 74: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f6bb05f_982f250a PS1, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f0acc953_ae9e35b3 PS1, Line 74: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a90de279_f6609c98 PS1, Line 90: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6a75ba3_3383e88f PS1, Line 90: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/314b1835_9e689fe6 PS1, Line 95: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9748f253_40f167a0 PS1, Line 102: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f8e216c_3b3c0b4c PS1, Line 109: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/096aaaf1_ba77b8be PS1, Line 114: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/824eab77_c6bc3e68 PS1, Line 122: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/474c972a_6a419c16 PS1, Line 130: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9439b519_ec31eef5 PS1, Line 135: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79def50a_00a498a1 PS1, Line 145: std::string args = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7517389a_cfc54473 PS1, Line 148: std::cout << "Using Device: " << dev->get_pp_string() << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/412385d4_b19b17be PS1, Line 153: uhd::tune_request_t tune_request(freq, 0); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c92c8e7a_41d13972 PS1, Line 162: std::this_thread::sleep_for(std::chrono::milliseconds(lock_delay_ms)); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/17c4a48c_746015e4 PS1, Line 164: uhd::stream_args_t stream_args("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a4a0234e_a2c96c33 PS1, Line 166: uhd::stream_args_t stream_args2("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/74376215_85e3f7a0 PS1, Line 177: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a73375dc_dff67b05 PS1, Line 182: uhd::rx_metadata_t md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cfb4eb24_3af1105e PS1, Line 186: std::cerr << boost::format("Timeout while streaming") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1e88918_6b8dcda2 PS1, Line 190: std::cerr << boost::format("Got an overflow indication\n") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d5e215b_1a083e50 PS1, Line 194: std::cerr << str(boost::format("Receiver error: %s") % md.strerror()); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/055c876c_4b8756b2 PS1, Line 209: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b05aa8bf_58b9bd3f PS1, Line 211: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/606a84e7_809d91c3 PS1, Line 214: uhd::stream_cmd_t stream_cmd(uhd::stream_cmd_t::STREAM_MODE_START_CONTINUOUS); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/270d661e_e7c27982 PS1, Line 225: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7cb63d98_67d20081 PS1, Line 227: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2daa4ac5_88f74c48 PS1, Line 232: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18dfb3e0_9ca9aaa1 PS1, Line 234: uhd::tx_metadata_t m = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ab5d0165_f821b4ed PS1, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3edc6ee2_b42f5263 PS1, Line 239: std::vector<void *> ptrs(1, buffer); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/481e9f1b_787d70a5 PS1, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ff1995f3_4e0ced24 PS1, Line 239: std::vector<void *> ptrs(1, buffer); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3a660f80_6cdd329b PS1, Line 243: uhd::async_metadata_t async_md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/64a23066_d5d2cbc0 PS1, Line 248: std::cout << (tx_ack ? "yay" : "nay") << " " << async_md.time_spec.to_ticks(rxticks) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c3680243_929f7ba0 PS1, Line 251: }; adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 01 Dec 2022 11:01:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment