Change in osmocom-bb[master]: trxcon: trx_if_close(): power the transceiver off if needed - gerrit-log

25 Jul 2022


      Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28794 )
Change subject: trxcon: trx_if_close(): power the transceiver off if needed
......................................................................
Patch Set 3:
(1 comment)
File src/host/trxcon/src/trx_if.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28794/comment/2a2f2998_a1977fa3 
PS2, Line 779: 	if (trx->powered_up)
...
imho the transceiver should power off as soon as the conn is detected closed?
It should, yes. But currently it may happen that the transceiver is not getting powered off properly. The trxcon_fsm is broken and needs to be reworked (I am on this already). I am adding this just to be sure.
-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28794
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I9c5178907304b36ec3de0ee31b7f7a9ed2e31c16
Gerrit-Change-Number: 28794
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 25 Jul 2022 18:06:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment