Attention is currently required from: arehbein, pespin, fixeria.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31885 )

Change subject: PCU IF: Update NSE timer field ......................................................................

Patch Set 1:

(1 comment)

File include/osmo-bts/pcuif_proto.h:

https://gerrit.osmocom.org/c/osmo-bts/+/31885/comment/76c78d05_cc599e2f PS1, Line 156: PCU_IF_NUM_NSE_TIMERS

Ah of course, didn't think of that @fixeria. […]

You could move nse_timer[] to the end of the struct. This wouldn't break the ABI, but in case a new timer has to be added you cannot easily enlarge the array.

I see there are already some txxx and nxxx variables in this struct. Why not adding the 8 timers as separate variables at the end of the struct?

(Are we limited in space here? What if the info_ind grows larger than struct gsm_pcu_if_data, which seems to be the biggest struct at the moment.)