Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476 )

Change subject: Support forwarding messages with multiple BSCs ......................................................................

Patch Set 2:

(6 comments)

File doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg:

https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476/comment/305d5e25_b04733ed PS1, Line 16: sccp-address bsc

why is this dropped in this patch?

It's not useful to hardcode one BSC's address in the config anymore, with this patch only the dynamically stored BSCs (as soon as they send their RESET) get used. This part of the config was read by sccp_sap_get_peer_addr_out in bsc_nat_fsm.c, which gets dropped in this patch.

File include/osmocom/bsc_nat/bsc_nat.h:

https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476/comment/c86a1bdb_7ea8eb31 PS1, Line 49: struct conn {

subscr_conn? conn seems to generic, too many layers, protocols, levels. […]

Done

https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476/comment/03636b9d_e4ad1c0f PS1, Line 87: void bsc_nat_conn_del(struct conn *conn);

subscr_conn_free()

Done

File src/osmo-bsc-nat/bsc_nat.c:

https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476/comment/980afcf0_64679fd7 PS1, Line 121: llist_for_each_entry(conn, &bsc_nat->conns, list) {

for_each_entry_safe

Done

https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476/comment/8c2a4248_25bb9de9 PS1, Line 131: llist_for_each_entry(conn, &bsc_nat->conns, list) {

for_each_entry_safe

Done

https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476/comment/b6250258_c66b3920 PS1, Line 241: llist_for_each_entry(msc, &bsc_nat->mscs, list) {

for_each_entry_safe (previous commit)

Done