Attention is currently required from: jolly. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720 ) Change subject: MGW_Tests: Add test for "confecho" connection. ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File mgw/MGCP_Test.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720/comment/990f5354_6b4a… PS1, Line 2309: f_flow_delete(RTPEM[1]); In TC_two_crcx_and_one_mdcx_rtp_ho we do this the other way around, I don't remember where the catch was, if there was any... (not critical, keep it like this if it works) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720/comment/23aa7242_669f… PS1, Line 2317: setverdict(fail); the setverdict also supports a string to explain what failed. like: setverdict(fail, "Received a different amount of RTP packets then sent"); This makes finding faults a lot easier. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7df4a58ad9287a564b2daf7548b882c03787f7f2 Gerrit-Change-Number: 33720 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 12 Jul 2023 13:44:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment