Attention is currently required from: jolly.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720 )
Change subject: MGW_Tests: Add test for "confecho" connection. ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File mgw/MGCP_Test.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720/comment/990f5354_6b4a4... PS1, Line 2309: f_flow_delete(RTPEM[1]); In TC_two_crcx_and_one_mdcx_rtp_ho we do this the other way around, I don't remember where the catch was, if there was any...
(not critical, keep it like this if it works)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720/comment/23aa7242_669ff... PS1, Line 2317: setverdict(fail); the setverdict also supports a string to explain what failed. like: setverdict(fail, "Received a different amount of RTP packets then sent"); This makes finding faults a lot easier.
-
dexter