laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36926?usp=email ) Change subject: pysim/euicc: Remove duplicated code ...................................................................... pysim/euicc: Remove duplicated code The get_eid command is actually sending the command apdu twice, as it contains both an older implementation (result unused) and the newer one. Change-Id: Ie82bb09f4fc30bc879029b83147dad5614792b48 --- M pySim/euicc.py 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/euicc.py b/pySim/euicc.py index 1683cac..e32fa4d 100644 --- a/pySim/euicc.py +++ b/pySim/euicc.py @@ -488,7 +488,6 @@ def do_get_eid(self, _opts): """Perform an ES10c GetEID function.""" - (_data, _sw) = CardApplicationISDR.store_data(self._cmd.lchan.scc, 'BF3E035C015A') ged_cmd = GetEuiccData(children=[TagList(decoded=[0x5A])]) ged = CardApplicationISDR.store_data_tlv(self._cmd.lchan.scc, ged_cmd, GetEuiccData) d = ged.to_dict() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36926?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie82bb09f4fc30bc879029b83147dad5614792b48 Gerrit-Change-Number: 36926 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged