Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37685?usp=email ) Change subject: pySim-shell: Support other ADMx values beyond ADM1 from 'verify_adm' ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This makes the linter happy: ```diff diff --git a/pySim-shell.py b/pySim-shell.py index 174df62..6ee127e 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -839,7 +839,8 @@ class PySimCommands(CommandSet): to get write/update permissions to most of the files on SIM cards. """ if opts.adm_type: - adm_chv_num = pin_names.inverse[opts.adm_type] + pin_values = dict(pin_names.inverse) + adm_chv_num = pin_values[opts.adm_type] else: adm_chv_num = self._cmd.card._adm_chv_num if opts.ADM: ``` But I think we can just do `pylint: disable=unsubscriptable-object`. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37685?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icce6903c1e449889f8bc5003ccfe6af767a26d44 Gerrit-Change-Number: 37685 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 02 Aug 2024 10:15:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment