Attention is currently required from: falconia, fixeria, neels. nt2mku has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email ) Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported ...................................................................... Patch Set 10: (3 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/901fd734_2bb085b8 PS7, Line 9: Some early GSM phones (like the Siemens P1 Porty) do not accept a mobile-terminating call setup if octet 3a is present. Done File src/gsm/gsm48_ie.c: https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/3c589f4f_f7ec6a0b PS7, Line 322: int encode_3a = 0; Done https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/a5aa362a_3857a23b PS7, Line 340: encode_3a == 1 Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 10 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 May 2024 07:11:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: comment