Attention is currently required from: fixeria, jolly.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email )
Change subject: Add LLC and HLC transcoding to MNCC transcoding functions ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3: To me it's even clearer now that these structs and related APIs are not really needed. I mean, it's just a buffer plus a related buffer len. We have/use tons of those all around, imagine we had to add structs for all types of buffer+len, it makes no sense imho.
Letting others provide feedback here.
File include/osmocom/gsm/mncc.h:
https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/2cad1d71_f7c1a16f PS3, Line 37: int len; this should be unsigned. And probably uint8_t.