Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29674 ) Change subject: debug: print socket info in log messages ...................................................................... Patch Set 1: (1 comment) File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29674/comment/1cf33e40_ef307b87 PS1, Line 1577: osmo_stream_srv_link_get_sockname(osmo_stream_srv_get_master(conn))); A test printing different stuff doesn't look like a valid reason to me. Either fix the test to use always the same stuff, or modify the test expectations in the log to filter that part in the line (we have some filtering features available when matching test output IIRC, @neels probably remembers betters). -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic8c9b0e5a67f0454fe850a80dfd7e6c2b3208b2c Gerrit-Change-Number: 29674 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 17:28:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment