laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37943?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: PFCP: fix SEID value in {ts,tr}_PFCP_Session_Est_Req ...................................................................... PFCP: fix SEID value in {ts,tr}_PFCP_Session_Est_Req According to 3GPP TS 29.244, section 7.2.2.4.2 "Conditions for Sending SEID=0 in PFCP Header": if a peer's SEID is not available, the SEID field shall still be present in the header and its value shall be set to "0" in the following messages: * PFCP Session Establishment Request message on Sxa/Sxb/Sxc/N4; ... Change-Id: Iacfbd68336b6fc4481c15ca5b304636df4491da4 Related: SYS#6772 --- M library/PFCP_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/library/PFCP_Templates.ttcn b/library/PFCP_Templates.ttcn index 329ea88..143175a 100644 --- a/library/PFCP_Templates.ttcn +++ b/library/PFCP_Templates.ttcn @@ -499,7 +499,7 @@ Create_PDR_list create_pdr, Create_FAR_list create_far) modifies ts_PDU_PFCP_ := { - seid := omit, /* FIXME: shall be set to 0 as per 7.2.2.4.2 */ + seid := '0000000000000000'O, /* shall be set to 0 as per 7.2.2.4.2 */ message_body := { pfcp_session_establishment_request := { node_id := node_id, @@ -519,7 +519,7 @@ template (present) PDU_PFCP tr_PFCP_Session_Est_Req(template (present) Node_ID node_id := ?) modifies tr_PDU_PFCP_ := { - seid := ?, + seid := '0000000000000000'O, /* shall be set to 0 as per 7.2.2.4.2 */ message_body := { pfcp_session_establishment_request := { node_id := node_id, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37943?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iacfbd68336b6fc4481c15ca5b304636df4491da4 Gerrit-Change-Number: 37943 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>