Attention is currently required from: dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30717 ) Change subject: GPRS Trau frame encoder/decoder for Ericsson RBS ...................................................................... Patch Set 2: (9 comments) File src/trau/trau_pcu_ericsson.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2121): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/6146a453_fbf12b19 PS2, Line 502: osmo_pbit2ubit_ext(trau_bits, 22, (pbit_t *)& ind->tav, 0, 2, 1); space prohibited after that '&' (ctx:VxW) File tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2121): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/fc86e842_910738cd PS2, Line 373: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2121): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/20adc73c_867f864a PS2, Line 387: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2121): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/d39c87fa_288ba7a3 PS2, Line 401: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2121): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/ec404d70_a0a831aa PS2, Line 1248: /* [...] shortened since decode wont access filler bits after 'wont' may be misspelled - perhaps 'won't'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2121): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/566d580b_35ea8a80 PS2, Line 1307: /* [...] shortened since decode wont access filler bits after 'wont' may be misspelled - perhaps 'won't'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2121): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/7434d7b0_05500126 PS2, Line 1319: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2121): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/02d33041_ce457d52 PS2, Line 1333: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2121): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/bc51b8a3_a9b61b80 PS2, Line 1347: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev); Use %d instead of %i -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib2b232a76588c32cde75b987a7e5fdfddf099cd7 Gerrit-Change-Number: 30717 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Dec 2022 14:20:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment