Attention is currently required from: pespin, dexter.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33634 )
Change subject: S1AP_Templates: fix tr_S1AP_SetupResp
......................................................................
Patch Set 1:
(1 comment)
File library/s1ap/S1AP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33634/comment/9f39ee31_d75e…
PS1, Line 116: *, {
Same, add a new line.
I don't know if the
protocolIEs field ends up being a "set of" or "record of" in TTCN3.
If it was "set of", we could use the "superset" matching mechanism,
which would basically make sure that any protocolIEs would match, in any order, just as
long as they contain each of the ones we specify here.
Also/Unrelated: IF the spec says there is only *one* intermediate IE permitted, we better
use "?" instead of "*", as the latter matches any number of
intermediate IEs.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33634
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I07513743142f519481530801d4e1185d55f6ea4b
Gerrit-Change-Number: 33634
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 09 Jul 2023 08:00:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment