Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434?usp=email ) Change subject: bl updater app ...................................................................... Patch Set 3: (322 comments) File CMSIS/Include/cmsis_version.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/675b6f4f_f60752c… : PS3, Line 1: /**************************************************************************//** trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/050c3176_8c2b846… : PS3, Line 2: * @file cmsis_version.h trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8475c5ef_379855d… : PS3, Line 3: * @brief CMSIS Core(M) Version definitions trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/0d2d5bc9_ea63dcd… : PS3, Line 4: * @version V5.0.2 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/624713db_2e4a109… : PS3, Line 5: * @date 19. April 2017 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/90e86adc_2c0ed3f… : PS3, Line 6: ******************************************************************************/ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/918077d6_ac19029… : PS3, Line 7: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f50a4938_2902de6… : PS3, Line 8: * Copyright (c) 2009-2017 ARM Limited. All rights reserved. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/937f8d00_7c87a9a… : PS3, Line 9: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/b8b53957_09b43f8… : PS3, Line 10: * SPDX-License-Identifier: Apache-2.0 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/7a34c2e5_4b7ccd3… : PS3, Line 11: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/ddaaa62a_f7a04fc… : PS3, Line 12: * Licensed under the Apache License, Version 2.0 (the License); you may trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/6bf2198d_a6b6663… : PS3, Line 13: * not use this file except in compliance with the License. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/93e7c7da_3f3d531… : PS3, Line 14: * You may obtain a copy of the License at trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/331010d5_354e052… : PS3, Line 15: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/0074e2c3_557d8ea… : PS3, Line 16: * www.apache.org/licenses/LICENSE-2.0 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/c5b37212_a31056d… : PS3, Line 17: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8f0023e3_0e8acaa… : PS3, Line 18: * Unless required by applicable law or agreed to in writing, software trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/45009aa4_c0866a2… : PS3, Line 19: * distributed under the License is distributed on an AS IS BASIS, WITHOUT trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/46d29b93_e526849… : PS3, Line 20: * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f2b5e8bf_34798a6… : PS3, Line 21: * See the License for the specific language governing permissions and trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/508f32c4_f21d94a… : PS3, Line 22: * limitations under the License. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/d23d5f2d_df77138… : PS3, Line 23: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/57d27d4a_bbd7180… : PS3, Line 24: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/e6ce6169_24b5511… : PS3, Line 25: #if defined ( __ICCARM__ ) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/59affe71_309b678… : PS3, Line 25: #if defined ( __ICCARM__ ) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/e34f6d31_fb2641d… : PS3, Line 25: #if defined ( __ICCARM__ ) space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/c4dc937f_deac6b4… : PS3, Line 25: #if defined ( __ICCARM__ ) space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/454bf3ec_c7475d7… : PS3, Line 26: #pragma system_include /* treat file as system include file for MISRA check */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/e14de423_eab335b… : PS3, Line 27: #elif defined (__clang__) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/532341d2_6f0c6b3… : PS3, Line 27: #elif defined (__clang__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/4360bb87_bb89338… : PS3, Line 28: #pragma clang system_header /* treat file as system include file */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/75456734_0167499… : PS3, Line 29: #endif DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/901ccbb3_bedb430… : PS3, Line 30: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/75c52e0a_1409c8b… : PS3, Line 31: #ifndef __CMSIS_VERSION_H DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/0f05935e_d5fef77… : PS3, Line 32: #define __CMSIS_VERSION_H DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/6e2c3d1c_d38c598… : PS3, Line 33: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/38981c46_0748318… : PS3, Line 34: /* CMSIS Version definitions */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/b4e8c307_0407fbe… : PS3, Line 35: #define __CM_CMSIS_VERSION_MAIN ( 5U) /*!< [31:16] CMSIS Core(M) main version */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/3e98d90a_0bcf994… : PS3, Line 35: #define __CM_CMSIS_VERSION_MAIN ( 5U) /*!< [31:16] CMSIS Core(M) main version */ space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/87878a2a_3e844b3… : PS3, Line 36: #define __CM_CMSIS_VERSION_SUB ( 1U) /*!< [15:0] CMSIS Core(M) sub version */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/e962dad2_5db2b7a… : PS3, Line 36: #define __CM_CMSIS_VERSION_SUB ( 1U) /*!< [15:0] CMSIS Core(M) sub version */ space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/51e33dd8_944ab02… : PS3, Line 37: #define __CM_CMSIS_VERSION ((__CM_CMSIS_VERSION_MAIN << 16U) | \ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/0ccf9d71_2139c9b… : PS3, Line 37: #define __CM_CMSIS_VERSION ((__CM_CMSIS_VERSION_MAIN << 16U) | \ Whitespace after \ makes next lines useless Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/3c9197fb_4ae7a2b… : PS3, Line 38: __CM_CMSIS_VERSION_SUB ) /*!< CMSIS Core(M) version number */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/573dc333_621a6e9… : PS3, Line 38: __CM_CMSIS_VERSION_SUB ) /*!< CMSIS Core(M) version number */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/0c19163f_f06afed… : PS3, Line 38: __CM_CMSIS_VERSION_SUB ) /*!< CMSIS Core(M) version number */ please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/409ee172_6167cea… : PS3, Line 38: __CM_CMSIS_VERSION_SUB ) /*!< CMSIS Core(M) version number */ space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f558455a_d17c8b6… : PS3, Line 39: #endif DOS line endings File hpl/core/hpl_core_m4.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f457e388_9b8c459… : PS3, Line 220: __asm(".align 3 \n" unnecessary whitespace before a quoted newline Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/9138d216_91ae327… : PS3, Line 226: ".align 3 \n" unnecessary whitespace before a quoted newline File hpl/sercom/hpl_sercom.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/94208abf_e60104a… : PS3, Line 89: | (CONF_SERCOM_##n##_USART_RUNSTDBY << SERCOM_USART_CTRLA_RUNSTDBY_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/49aff5d9_bb87a5d… : PS3, Line 90: | (CONF_SERCOM_##n##_USART_IBON << SERCOM_USART_CTRLA_IBON_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/4d7882eb_639a808… : PS3, Line 91: | (CONF_SERCOM_##n##_USART_TXINV << SERCOM_USART_CTRLA_TXINV_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/55762feb_2ee5f7b… : PS3, Line 92: | (CONF_SERCOM_##n##_USART_RXINV << SERCOM_USART_CTRLA_RXINV_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8223d806_eec24b2… : PS3, Line 93: | SERCOM_USART_CTRLA_SAMPR(CONF_SERCOM_##n##_USART_SAMPR) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/9cccae8a_25aab33… : PS3, Line 94: | SERCOM_USART_CTRLA_TXPO(CONF_SERCOM_##n##_USART_TXPO) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8ceca226_8832f8c… : PS3, Line 95: | SERCOM_USART_CTRLA_RXPO(CONF_SERCOM_##n##_USART_RXPO) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/53d05104_3a72288… : PS3, Line 96: | SERCOM_USART_CTRLA_SAMPA(CONF_SERCOM_##n##_USART_SAMPA) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8eecc894_c50032f… : PS3, Line 97: | SERCOM_USART_CTRLA_FORM(CONF_SERCOM_##n##_USART_FORM) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/82f89882_070d3c7… : PS3, Line 98: | (CONF_SERCOM_##n##_USART_CMODE << SERCOM_USART_CTRLA_CMODE_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/3bafb7fd_0e843e1… : PS3, Line 99: | (CONF_SERCOM_##n##_USART_CPOL << SERCOM_USART_CTRLA_CPOL_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/c89e029d_a564abd… : PS3, Line 100: | (CONF_SERCOM_##n##_USART_DORD << SERCOM_USART_CTRLA_DORD_Pos), \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/66e2983a_e32d91c… : PS3, Line 102: | (CONF_SERCOM_##n##_USART_SBMODE << SERCOM_USART_CTRLB_SBMODE_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8d32fed9_756cab7… : PS3, Line 103: | (CONF_SERCOM_##n##_USART_CLODEN << SERCOM_USART_CTRLB_COLDEN_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8bd0745b_22c8ef8… : PS3, Line 104: | (CONF_SERCOM_##n##_USART_SFDE << SERCOM_USART_CTRLB_SFDE_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/414c0250_55caa53… : PS3, Line 105: | (CONF_SERCOM_##n##_USART_ENC << SERCOM_USART_CTRLB_ENC_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/6438a211_470426a… : PS3, Line 106: | (CONF_SERCOM_##n##_USART_PMODE << SERCOM_USART_CTRLB_PMODE_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/50585297_944c29b… : PS3, Line 107: | (CONF_SERCOM_##n##_USART_TXEN << SERCOM_USART_CTRLB_TXEN_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/d2f5a2d6_478be92… : PS3, Line 108: | (CONF_SERCOM_##n##_USART_RXEN << SERCOM_USART_CTRLB_RXEN_Pos), \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/13b3b526_a58cfaf… : PS3, Line 110: | (CONF_SERCOM_##n##_USART_DSNACK << SERCOM_USART_CTRLC_DSNACK_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/2bf95f3b_cc1a34f… : PS3, Line 111: | (CONF_SERCOM_##n##_USART_INACK << SERCOM_USART_CTRLC_INACK_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/244328f5_a858889… : PS3, Line 112: | SERCOM_USART_CTRLC_MAXITER(CONF_SERCOM_##n##_USART_MAXITER), \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/3597467b_a77abac… : PS3, Line 140: SERCOM_CONFIGURATION(0), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/751825c1_9634b41… : PS3, Line 143: SERCOM_CONFIGURATION(1), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/5058a56e_ac55d89… : PS3, Line 146: SERCOM_CONFIGURATION(2), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/1449ed3b_ef7f169… : PS3, Line 149: SERCOM_CONFIGURATION(3), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8276cf7e_2bf32ac… : PS3, Line 152: SERCOM_CONFIGURATION(4), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/db1821de_5ffaa45… : PS3, Line 155: SERCOM_CONFIGURATION(5), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/825b2e20_868aa81… : PS3, Line 158: SERCOM_CONFIGURATION(6), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/90356498_ddd908d… : PS3, Line 161: SERCOM_CONFIGURATION(7), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/4532f264_c962c93… : PS3, Line 188: const enum usart_baud_rate_mode mode, const uint8_t fraction); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/250684da_096c76a… : PS3, Line 188: const enum usart_baud_rate_mode mode, const uint8_t fraction); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/67470641_a6b2c64… : PS3, Line 218: if (init_status) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/5dabbfa8_8fd61b1… : PS3, Line 254: const enum usart_baud_rate_mode mode, const uint8_t fraction) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/b10985d7_1d5db84… : PS3, Line 254: const enum usart_baud_rate_mode mode, const uint8_t fraction) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/33ad60c2_4ff9f85… : PS3, Line 263: const enum usart_baud_rate_mode mode, const uint8_t fraction) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/42c4ea4c_0b261b6… : PS3, Line 263: const enum usart_baud_rate_mode mode, const uint8_t fraction) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/07f66332_f8d1caf… : PS3, Line 471: void _usart_sync_set_flow_control_state(struct _usart_sync_device *const device, "foo *const bar" should be "foo *const bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/96080f5a_2438309… : PS3, Line 472: const union usart_flow_control_state state) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/eab40031_0d774b5… : PS3, Line 472: const union usart_flow_control_state state) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/4835f630_cdd0714… : PS3, Line 481: void _usart_async_set_flow_control_state(struct _usart_async_device *const device, "foo *const bar" should be "foo *const bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/5472f6d8_a39bc90… : PS3, Line 482: const union usart_flow_control_state state) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/5de67255_1f294ff… : PS3, Line 482: const union usart_flow_control_state state) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/aaeebb16_8ad4265… : PS3, Line 535: Sercom *const sercom_modules[] = SERCOM_INSTS; need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/4d66c075_2be65e1… : PS3, Line 538: if ((uint32_t)hw == (uint32_t)sercom_modules[i]) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/c3c7d606_026da79… : PS3, Line 565: const bool state) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/250d483f_ed4ce1e… : PS3, Line 565: const bool state) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f223db45_cb01ab6… : PS3, Line 626: if (_usarts[i].number == sercom_offset) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/20bb131e_8053e27… : PS3, Line 641: if (hw == SERCOM0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/842f9821_6d6ed31… : PS3, Line 645: if (hw == SERCOM1) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/14554c21_4e9196f… : PS3, Line 649: if (hw == SERCOM2) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/1b777547_f975716… : PS3, Line 653: if (hw == SERCOM3) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/720421b8_0295e11… : PS3, Line 657: if (hw == SERCOM4) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f579c879_05efa50… : PS3, Line 661: if (hw == SERCOM5) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/2b2e0867_2977ee5… : PS3, Line 665: if (hw == SERCOM6) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/1d7d8e10_6af0b43… : PS3, Line 730: const enum usart_baud_rate_mode mode, const uint8_t fraction) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/c109ec2b_3571561… : PS3, Line 730: const enum usart_baud_rate_mode mode, const uint8_t fraction) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/bfd191d1_f3e481c… : PS3, Line 732: if (USART_BAUDRATE_ASYNCH_ARITHMETIC == mode) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/234238a4_f4ec47f… : PS3, Line 736: if (USART_BAUDRATE_ASYNCH_FRACTIONAL == mode) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/3df9ed5c_ef7dcda… : PS3, Line 740: if (USART_BAUDRATE_SYNCH == mode) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/ee5e0d74_e46a9ce… : PS3, Line 822: if (USART_PARITY_NONE != parity) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/6b6efce8_9870bb6… : PS3, Line 871: if (enabled) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/b1101977_b251917… : PS3, Line 918: | (CONF_SERCOM_##n##_I2CM_SPEED << SERCOM_I2CM_CTRLA_SPEED_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/fc7277be_700605b… : PS3, Line 919: | (CONF_SERCOM_##n##_I2CM_MEXTTOEN << SERCOM_I2CM_CTRLA_MEXTTOEN_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/6b760db1_f1098ac… : PS3, Line 920: | (CONF_SERCOM_##n##_I2CM_SEXTTOEN << SERCOM_I2CM_CTRLA_SEXTTOEN_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/a49c2b31_ed4eefb… : PS3, Line 921: | (CONF_SERCOM_##n##_I2CM_INACTOUT << SERCOM_I2CM_CTRLA_INACTOUT_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/a6b7e2dd_b9dbe66… : PS3, Line 922: | (CONF_SERCOM_##n##_I2CM_LOWTOUT << SERCOM_I2CM_CTRLA_LOWTOUTEN_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/07105ba1_89149c1… : PS3, Line 923: | (CONF_SERCOM_##n##_I2CM_SDAHOLD << SERCOM_I2CM_CTRLA_SDAHOLD_Pos), \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/9a93e69d_2fd2892… : PS3, Line 966: I2CM_CONFIGURATION(0), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/35ede16c_30a1cab… : PS3, Line 969: I2CM_CONFIGURATION(1), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f5b2ea63_1c618fc… : PS3, Line 972: I2CM_CONFIGURATION(2), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/d486ba0b_956de34… : PS3, Line 975: I2CM_CONFIGURATION(3), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/37cef0ea_47ea8a6… : PS3, Line 978: I2CM_CONFIGURATION(4), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/7b5f7015_352b378… : PS3, Line 981: I2CM_CONFIGURATION(5), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/690b3910_ff224a1… : PS3, Line 984: I2CM_CONFIGURATION(6), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f52eb8b9_9707df5… : PS3, Line 987: I2CM_CONFIGURATION(7), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/062d0fe3_844202c… : PS3, Line 1005: if (_i2cms[i].number == sercom_offset) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/4cbf4767_ef80e68… : PS3, Line 1034: if (status & SERCOM_I2CM_STATUS_BUSERR) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/94532f90_e808ed1… : PS3, Line 1039: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/b02e2f6b_55392ac… : PS3, Line 1043: if (msg->len > 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/0618057e_1a46361… : PS3, Line 1047: if (msg->flags & I2C_M_STOP) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/4e6d08ba_e84fa43… : PS3, Line 1058: ((((msg->addr & TEN_ADDR_MASK) >> 8) | TEN_ADDR_FRAME) << 1) | I2C_M_RD code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/7b29b18c_a1f62b3… : PS3, Line 1059: | (hri_sercomi2cm_read_ADDR_reg(hw) & SERCOM_I2CM_ADDR_HS)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/34948212_a870c28… : PS3, Line 1066: if (msg->flags & I2C_M_STOP) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/ac90f250_942fd69… : PS3, Line 1084: if ((msg->len == 0 && !sclsm) || (msg->len == 1 && sclsm)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/83b563b7_02e5450… : PS3, Line 1153: void * hw = i2c_dev->hw; "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/868e62d0_d1f3f3b… : PS3, Line 1155: if (hri_sercomi2cm_get_CTRLA_ENABLE_bit(hw)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f1623925_8ea09e3… : PS3, Line 1164: / (2 * baudrate)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/72622059_67e64ca… : PS3, Line 1168: / (2 * baudrate)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/bbc535de_1f43033… : PS3, Line 1203: if (init_status) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/91d291cf_e2f0df1… : PS3, Line 1240: void * hw = i2c_dev->hw; "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/de13e68e_83db3d1… : PS3, Line 1246: if (msg->len == 1 && sclsm) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/1bc22688_0169fc4… : PS3, Line 1254: if (msg->flags & I2C_M_RD) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/cebf2b88_673d598… : PS3, Line 1259: ((msg->addr & TEN_ADDR_MASK) << 1) | SERCOM_I2CM_ADDR_TENBITEN code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/59d8af84_d865166… : PS3, Line 1260: | (hri_sercomi2cm_read_ADDR_reg(hw) & SERCOM_I2CM_ADDR_HS)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/fbcba23b_1dc6f18… : PS3, Line 1263: ((msg->addr & SEVEN_ADDR_MASK) << 1) | (msg->flags & I2C_M_RD ? I2C_M_RD : 0x0) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/071850e1_43b0c73… : PS3, Line 1264: | (hri_sercomi2cm_read_ADDR_reg(hw) & SERCOM_I2CM_ADDR_HS)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/39aaf07c_97ba736… : PS3, Line 1288: if (msg->len == 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/ee3e6944_2af1e26… : PS3, Line 1292: if (i2c_dev->service.msg.flags & I2C_M_BUSY) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/9bac2837_6557e95… : PS3, Line 1319: FUNC_PTR func) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/2cb087c5_e1400e1… : PS3, Line 1319: FUNC_PTR func) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/dcd0f3d9_1230dec… : PS3, Line 1345: * \retval I2C_OK Operation was successfull 'successfull' may be misspelled - perhaps 'successful'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/a80046d9_275daf9… : PS3, Line 1366: if (i2c_dev->service.msg.flags & I2C_M_BUSY) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/c67cb69a_c7c80dc… : PS3, Line 1441: void * hw = i2c_dev->hw; "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/cde0b22d_2244347… : PS3, Line 1443: if (hri_sercomi2cm_get_CTRLA_ENABLE_bit(hw)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/37206a74_1658469… : PS3, Line 1452: / (2 * baudrate)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/799ed168_51d6a2e… : PS3, Line 1456: / (2 * baudrate)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/b07e26cf_21287c0… : PS3, Line 1473: const bool state) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/5733b49e_6dcd63e… : PS3, Line 1473: const bool state) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/30a56169_93bf088… : PS3, Line 1493: inline static int32_t _sercom_i2c_sync_wait_bus(struct _i2c_m_sync_device *const i2c_dev, uint32_t *flags) inline keyword should sit between storage class and type Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f3f7c9ea_111ff84… : PS3, Line 1496: void * hw = i2c_dev->hw; "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/1d935d14_c8533c9… : PS3, Line 1501: if (timeout-- == 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/95bf6465_e324108… : PS3, Line 1516: void * hw = i2c_dev->hw; "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/a07a8912_00f5d8a… : PS3, Line 1523: if (msg->len == 1 && sclsm) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/fcf15938_34cdb8c… : PS3, Line 1531: if (msg->flags & I2C_M_RD) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/2d123607_8ed3724… : PS3, Line 1536: ((msg->addr & TEN_ADDR_MASK) << 1) | SERCOM_I2CM_ADDR_TENBITEN code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/ace03568_984bee4… : PS3, Line 1537: | (hri_sercomi2cm_read_ADDR_reg(hw) & SERCOM_I2CM_ADDR_HS)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/21974bb7_cc29c12… : PS3, Line 1540: ((msg->addr & SEVEN_ADDR_MASK) << 1) | (msg->flags & I2C_M_RD ? I2C_M_RD : 0x0) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/4a579041_e923e94… : PS3, Line 1541: | (hri_sercomi2cm_read_ADDR_reg(hw) & SERCOM_I2CM_ADDR_HS)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/7e0e3843_33b1af4… : PS3, Line 1562: void * hw = i2c_dev->hw; "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/55806e2c_6380a70… : PS3, Line 1568: if (i2c_dev->service.msg.flags & I2C_M_BUSY) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/de73a844_0ebf669… : PS3, Line 1588: if (msg->flags & I2C_M_STOP) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/e5ac38a3_c8bd9fb… : PS3, Line 1704: | SERCOM_I2CS_CTRLA_SDAHOLD(CONF_SERCOM_##n##_I2CS_SDAHOLD) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/3f53dfa8_d920acf… : PS3, Line 1705: | (CONF_SERCOM_##n##_I2CS_SEXTTOEN << SERCOM_I2CS_CTRLA_SEXTTOEN_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/3d15ed16_f712c6c… : PS3, Line 1706: | (CONF_SERCOM_##n##_I2CS_SPEED << SERCOM_I2CS_CTRLA_SPEED_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8e1cf1c0_45b7a8d… : PS3, Line 1707: | (CONF_SERCOM_##n##_I2CS_SCLSM << SERCOM_I2CS_CTRLA_SCLSM_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/6016a777_f8d3da3… : PS3, Line 1708: | (CONF_SERCOM_##n##_I2CS_LOWTOUT << SERCOM_I2CS_CTRLA_LOWTOUTEN_Pos), \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/ca2b9ada_0f8b788… : PS3, Line 1711: | SERCOM_I2CS_ADDR_ADDR(CONF_SERCOM_##n##_I2CS_ADDRESS) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/656914a7_e574e93… : PS3, Line 1712: | (CONF_SERCOM_##n##_I2CS_TENBITEN << SERCOM_I2CS_ADDR_TENBITEN_Pos) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/bcf6c673_e353165… : PS3, Line 1713: | SERCOM_I2CS_ADDR_ADDRMASK(CONF_SERCOM_##n##_I2CS_ADDRESS_MASK) \ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/71c8ac66_c919c7d… : PS3, Line 1745: I2CS_CONFIGURATION(0), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f900e872_1993bf6… : PS3, Line 1748: I2CS_CONFIGURATION(1), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/154ca887_f95accb… : PS3, Line 1751: I2CS_CONFIGURATION(2), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/c0178af4_b8c6ba0… : PS3, Line 1754: I2CS_CONFIGURATION(3), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/09a8e555_7dcaee5… : PS3, Line 1757: I2CS_CONFIGURATION(4), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/b69c829f_954498f… : PS3, Line 1760: I2CS_CONFIGURATION(5), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/9a29f64d_23ea251… : PS3, Line 1763: I2CS_CONFIGURATION(6), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/fab90d5e_efd2cfc… : PS3, Line 1766: I2CS_CONFIGURATION(7), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/e2f939ca_b8e83ec… : PS3, Line 1781: if (status) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/e58cb3fd_6f98ffe… : PS3, Line 1799: if (init_status) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/d7fc331a_fc176dc… : PS3, Line 1992: const bool state) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/98e8d071_2798f96… : PS3, Line 1992: const bool state) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/969c8da6_1c2a5a9… : PS3, Line 1996: if (I2C_S_DEVICE_TX == type || I2C_S_DEVICE_RX_COMPLETE == type) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/08e50739_8da0174… : PS3, Line 2006: * \internal Initalize i2c slave hardware 'Initalize' may be misspelled - perhaps 'Initialize'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/3438eb41_001a4fe… : PS3, Line 2015: if (i == -1) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/443e9727_c8d2861… : PS3, Line 2049: if (_i2css[i].number == sercom_offset) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/0ae3ff82_d21e2d7… : PS3, Line 2086: if (enabled) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/fca40a38_8b32bfa… : PS3, Line 2179: SERCOMSPI_REGS(0), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/ba944a18_4dc68e2… : PS3, Line 2182: SERCOMSPI_REGS(1), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/c63e6d77_c496927… : PS3, Line 2185: SERCOMSPI_REGS(2), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8b41c758_21a7116… : PS3, Line 2188: SERCOMSPI_REGS(3), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/c08557a3_603d7bd… : PS3, Line 2191: SERCOMSPI_REGS(4), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/b1f4fcde_b416c8e… : PS3, Line 2194: SERCOMSPI_REGS(5), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/1b05d862_4d86666… : PS3, Line 2197: SERCOMSPI_REGS(6), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/a1af5b60_c1b5795… : PS3, Line 2200: SERCOMSPI_REGS(7), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/b9fa34e8_36a3341… : PS3, Line 2227: if (hri_sercomspi_is_syncing(hw, SERCOM_SPI_SYNCBUSY_SWRST)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8a5ce915_8bd6d73… : PS3, Line 2246: for (uint32_t i = 0; i < 4; i++) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/0acd0e81_b4e6960… : PS3, Line 2261: if (hri_sercomspi_is_syncing(hw, SERCOM_SPI_SYNCBUSY_SWRST)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/894b482b_c3243c3… : PS3, Line 2281: for (uint32_t i = 0; i < 4; i++) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/b1e81f13_7b747fc… : PS3, Line 2299: if (hri_sercomspi_is_syncing(hw, SERCOM_SPI_SYNCBUSY_SWRST | SERCOM_SPI_SYNCBUSY_ENABLE)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/2c9123bb_ff5859c… : PS3, Line 2320: if (hri_sercomspi_is_syncing(hw, SERCOM_SPI_SYNCBUSY_SWRST)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/df81682b_6785607… : PS3, Line 2340: if (!(char_size == SPI_CHAR_SIZE_8 || char_size == SPI_CHAR_SIZE_9)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/5ba3a72e_49a8fbe… : PS3, Line 2344: if (hri_sercomspi_is_syncing(hw, SERCOM_SPI_SYNCBUSY_SWRST | SERCOM_SPI_SYNCBUSY_CTRLB)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/d254b4ee_6bef9c8… : PS3, Line 2365: if (hri_sercomspi_is_syncing(hw, SERCOM_SPI_SYNCBUSY_SWRST)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/1a42ede2_1708970… : PS3, Line 2371: if (dord == SPI_DATA_ORDER_LSB_1ST) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/a0559766_4a39746… : PS3, Line 2396: | (SERCOM_SPI_CTRLB_RXEN)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/b006f232_3bf3d39… : PS3, Line 2413: (regs->ctrlb & ~(SERCOM_SPI_CTRLB_MSSEN)) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/c25266f6_b6c652c… : PS3, Line 2414: | (SERCOM_SPI_CTRLB_RXEN | SERCOM_SPI_CTRLB_SSDE | SERCOM_SPI_CTRLB_PLOADEN)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/7a3e749f_81982e6… : PS3, Line 2431: if (sercomspi_regs[i].n == n) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/0e8f3273_1809473… : PS3, Line 2648: if (regs == NULL) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/5e464429_031ad7f… : PS3, Line 2664: if ((regs->ctrla & SERCOM_SPI_CTRLA_MODE_Msk) == SERCOM_USART_CTRLA_MODE_SPI_SLAVE) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/2b7efa03_c489968… : PS3, Line 2689: if (rc < 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/86a04814_18f3029… : PS3, Line 2829: if (clk == 0 || baud == 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/72820e9e_00fae25… : PS3, Line 2834: if (!(baud <= (clk >> 1) && baud >= (clk >> 8))) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/d5f7602d_e0bc716… : PS3, Line 2915: while (!(hri_sercomspi_get_INTFLAG_reg(hw, SERCOM_SPI_INTFLAG_TXC | SERCOM_SPI_INTFLAG_DRE))) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/81142201_310fbd0… : PS3, Line 2940: if (!(iflag & SERCOM_SPI_INTFLAG_RXC)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/60ed9a14_2a71374… : PS3, Line 2949: if (ctrl->char_size > 1) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/6986b06f_82eaa15… : PS3, Line 2961: uint16_t dummy) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/c8842212_9033cd8… : PS3, Line 2961: uint16_t dummy) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/6da81781_9fe8d36… : PS3, Line 2965: if (!(SERCOM_SPI_INTFLAG_DRE & iflag)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/5655f849_53681b0… : PS3, Line 2998: void * hw = dev->prvt; "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/d396d192_36839fb… : PS3, Line 3006: hw, (SERCOM_SPI_SYNCBUSY_SWRST | SERCOM_SPI_SYNCBUSY_ENABLE | SERCOM_SPI_SYNCBUSY_CTRLB))) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/e1ca1606_78c0d10… : PS3, Line 3011: if (!hri_sercomspi_get_CTRLA_ENABLE_bit(hw)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/c75467d8_13bc2f0… : PS3, Line 3021: if (ctrl.rxcnt >= ctrl.txcnt) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/3db189d8_5704f74… : PS3, Line 3028: if (rc < 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/834b10be_8c36316… : PS3, Line 3048: if (state) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/db2c2c2e_772c831… : PS3, Line 3069: if (state) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/ecefcab1_0e1f7bd… : PS3, Line 3087: if (state) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/58a185d6_5a2c7e8… : PS3, Line 3150: const FUNC_PTR func) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/662d5c32_9017170… : PS3, Line 3150: const FUNC_PTR func) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/b7ebf311_44401b5… : PS3, Line 3164: const FUNC_PTR func) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/897e20d0_2dd7bd0… : PS3, Line 3164: const FUNC_PTR func) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/42b076dd_0075a4b… : PS3, Line 3218: const bool state) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/0a30249a_6c5d8d6… : PS3, Line 3218: const bool state) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/c14c1ec5_ae51c9b… : PS3, Line 3222: if (SPI_DEV_CB_ERROR == type) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/dfdccbd7_b07b20e… : PS3, Line 3235: const bool state) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/590d156d_20fa91f… : PS3, Line 3235: const bool state) please, no spaces at the start of a line File usb_dfu_main.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/d64e897d_c169287… : PS3, Line 36: static volatile const uint32_t bl_update_data[BLSZ_BYTE / sizeof(uint32_t)] __attribute__((section(".fwupdate"),used,retain)) = { 0xFF }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/301a118f_e794a47… : PS3, Line 36: static volatile const uint32_t bl_update_data[BLSZ_BYTE / sizeof(uint32_t)] __attribute__((section(".fwupdate"),used,retain)) = { 0xFF }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/546f567a_9d2c391… : PS3, Line 38: _Static_assert (BLSZ_BYTE % NVMCTRL_PAGE_SIZE == 0, "invalid bl size"); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8a302c48_f88022d… : PS3, Line 42: void same54_flash_write_page(uint32_t address, uint8_t *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/bc969597_6a173d6… : PS3, Line 44: while (!NVMCTRL->STATUS.bit.READY) {} please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/e6021a87_0f8e9cf… : PS3, Line 44: while (!NVMCTRL->STATUS.bit.READY) {} braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/baec7497_02927bd… : PS3, Line 48: while (!NVMCTRL->STATUS.bit.READY) {} please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/b92ffe6e_40f2f6b… : PS3, Line 48: while (!NVMCTRL->STATUS.bit.READY) {} braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/6f41cbba_f7ff898… : PS3, Line 51: volatile uint32_t *src = (uint32_t *)data; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f23d8d69_34f960f… : PS3, Line 53: for (uint32_t i = 0; i < (NVMCTRL_PAGE_SIZE / sizeof(uint32_t)); i++) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/81e9e94a_e2643ce… : PS3, Line 53: for (uint32_t i = 0; i < (NVMCTRL_PAGE_SIZE / sizeof(uint32_t)); i++) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/ec0391b3_f5a3832… : PS3, Line 54: dst[i] = src[i]; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/fee82271_85940ec… : PS3, Line 54: dst[i] = src[i]; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/11efac67_dfad031… : PS3, Line 55: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/6da35598_9bed411… : PS3, Line 57: NVMCTRL->ADDR.reg = address; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/db816d32_808ba1c… : PS3, Line 58: NVMCTRL->CTRLB.reg = NVMCTRL_CTRLB_CMD_WP | NVMCTRL_CTRLB_CMDEX_KEY; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/0062f717_67b44e7… : PS3, Line 59: while (!NVMCTRL->INTFLAG.bit.DONE) {} please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/b87df682_a395d35… : PS3, Line 59: while (!NVMCTRL->INTFLAG.bit.DONE) {} braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/e12906a8_0b014bf… : PS3, Line 60: while (!NVMCTRL->STATUS.bit.READY) {} please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/7278882f_9d35ae5… : PS3, Line 60: while (!NVMCTRL->STATUS.bit.READY) {} braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/d5bdd222_189d086… : PS3, Line 63: __attribute__((section(".ramfunc"),OPTNONE)) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f864001e_1a6815e… : PS3, Line 64: void do_update() { Bad function definition - void do_update() should probably be void do_update(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/bc61e4bc_5c61848… : PS3, Line 64: void do_update() { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/a9e23ced_cfc2f57… : PS3, Line 65: uint16_t mask = NVMCTRL_CTRLA_AHBNS0 |NVMCTRL_CTRLA_AHBNS1|NVMCTRL_CTRLA_RWS_Msk; need consistent spacing around '|' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/1196c4ae_d21984e… : PS3, Line 66: uint16_t _nvm = (NVMCTRL_CTRLA_CACHEDIS0 | NVMCTRL_CTRLA_CACHEDIS1 | NVMCTRL_CTRLA_PRM(3) | NVMCTRL_CTRLA_RWS(0x7) | NVMCTRL_CTRLA_WMODE(0) |NVMCTRL_CTRLA_AUTOWS ); need consistent spacing around '|' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/a12d663c_37de73c… : PS3, Line 66: uint16_t _nvm = (NVMCTRL_CTRLA_CACHEDIS0 | NVMCTRL_CTRLA_CACHEDIS1 | NVMCTRL_CTRLA_PRM(3) | NVMCTRL_CTRLA_RWS(0x7) | NVMCTRL_CTRLA_WMODE(0) |NVMCTRL_CTRLA_AUTOWS ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/71590dcf_84cd3ad… : PS3, Line 83: _Static_assert (BL_IN_REGIONS > 0, "bootprot regions must be at least 1"); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/706641dc_3316604… : PS3, Line 86: for(int i = 0; i< NVMCTRL_REGIONS_NUM; i++){ spaces required around that '<' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/0bce4df5_dd50f1d… : PS3, Line 86: for(int i = 0; i< NVMCTRL_REGIONS_NUM; i++){ space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/045a0277_6ceeecc… : PS3, Line 86: for(int i = 0; i< NVMCTRL_REGIONS_NUM; i++){ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/c4e22385_e66b464… : PS3, Line 87: while (!hri_nvmctrl_get_STATUS_READY_bit(NVMCTRL)) {} braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f5c15f1d_1c9ccee… : PS3, Line 88: hri_nvmctrl_write_ADDR_reg(NVMCTRL, REGION_SZ* i); need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/385bb886_7b5f48d… : PS3, Line 94: while (!hri_nvmctrl_get_STATUS_READY_bit(NVMCTRL)) {} braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/a41d80de_1dd9b3f… : PS3, Line 96: for(int i = 0; i< bootloader_regions; i++){ spaces required around that '<' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/71082617_cde78b9… : PS3, Line 96: for(int i = 0; i< bootloader_regions; i++){ space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f1714998_e931d3b… : PS3, Line 96: for(int i = 0; i< bootloader_regions; i++){ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/9f3627bc_86ee7d8… : PS3, Line 97: while (!hri_nvmctrl_get_STATUS_READY_bit(NVMCTRL)) {} braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f2de0201_d59565a… : PS3, Line 102: while (!hri_nvmctrl_get_STATUS_READY_bit(NVMCTRL)) {} braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/69cda634_f22c6c7… : PS3, Line 105: uint32_t address = 0; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f3e16efb_d8f5149… : PS3, Line 106: uint8_t *data_ptr = (uint8_t *)bl_update_data; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/acba2dde_7983b37… : PS3, Line 107: uint32_t remaining = BLSZ_BYTE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/21f407ae_233ac49… : PS3, Line 109: while (remaining >= NVMCTRL_PAGE_SIZE) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/dd7b767a_c00946e… : PS3, Line 110: same54_flash_write_page(address, data_ptr); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f5067eda_a7f22f2… : PS3, Line 110: same54_flash_write_page(address, data_ptr); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/2de069c2_1426df0… : PS3, Line 111: address += NVMCTRL_PAGE_SIZE; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/39089e2f_cf669de… : PS3, Line 111: address += NVMCTRL_PAGE_SIZE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/209c5d04_93f1a22… : PS3, Line 112: data_ptr += NVMCTRL_PAGE_SIZE; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/43db17bf_096be9f… : PS3, Line 112: data_ptr += NVMCTRL_PAGE_SIZE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/92b0b25d_fcc8ad4… : PS3, Line 113: remaining -= NVMCTRL_PAGE_SIZE; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/d57cb61f_ec97117… : PS3, Line 113: remaining -= NVMCTRL_PAGE_SIZE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/132e55ef_e468d40… : PS3, Line 114: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/0a34717f_e9082ba… : PS3, Line 117: for(int i = bootloader_regions; i < bootloader_regions+1; i++){ space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/1213b03b_4d06a83… : PS3, Line 117: for(int i = bootloader_regions; i < bootloader_regions+1; i++){ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/9a324a46_e66a1e7… : PS3, Line 118: while (!(((Nvmctrl *)NVMCTRL)->STATUS.reg & NVMCTRL_STATUS_READY) >> NVMCTRL_STATUS_READY_Pos) {} braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/ce948b9e_a690ed5… : PS3, Line 122: while (!(((Nvmctrl *)NVMCTRL)->STATUS.reg & NVMCTRL_STATUS_READY) >> NVMCTRL_STATUS_READY_Pos) {} braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/5eccf132_5f964c9… : PS3, Line 123: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/521b7465_6544c0e… : PS3, Line 125: SCB->AIRCR = (uint32_t)((0x5FAUL << SCB_AIRCR_VECTKEY_Pos) |(SCB->AIRCR & SCB_AIRCR_PRIGROUP_Msk) |SCB_AIRCR_SYSRESETREQ_Msk ); need consistent spacing around '|' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/674fe904_19b5a97… : PS3, Line 125: SCB->AIRCR = (uint32_t)((0x5FAUL << SCB_AIRCR_VECTKEY_Pos) |(SCB->AIRCR & SCB_AIRCR_PRIGROUP_Msk) |SCB_AIRCR_SYSRESETREQ_Msk ); need consistent spacing around '|' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/5d350165_fd62401… : PS3, Line 125: SCB->AIRCR = (uint32_t)((0x5FAUL << SCB_AIRCR_VECTKEY_Pos) |(SCB->AIRCR & SCB_AIRCR_PRIGROUP_Msk) |SCB_AIRCR_SYSRESETREQ_Msk ); space prohibited before that close parenthesis ')' File usb_flash_main.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/ae091a43_f25e9fe… : PS3, Line 18: * License along with this library; if not, write to the Free Software Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/35ea9043_568d25e… : PS3, Line 19: * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/4de5655b_8061024… : PS3, Line 30: static uint32_t* application_start_address = (uint32_t*)(BL_SIZE_BYTE); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/4519593a_6bb2435… : PS3, Line 30: static uint32_t* application_start_address = (uint32_t*)(BL_SIZE_BYTE); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/e70ef6e3_cdb2727… : PS3, Line 33: static volatile uint32_t* dfu_magic = (uint32_t*)HSRAM_ADDR; // magic value should be written at start of RAM "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/40c7067c_3b42fb3… : PS3, Line 33: static volatile uint32_t* dfu_magic = (uint32_t*)HSRAM_ADDR; // magic value should be written at start of RAM "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f02e610a_bc01fdf… : PS3, Line 109: static int str_to_usb_desc(char* in, uint8_t in_sz, uint8_t* out, uint8_t out_sz){ "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/095e3464_4edcb2c… : PS3, Line 109: static int str_to_usb_desc(char* in, uint8_t in_sz, uint8_t* out, uint8_t out_sz){ "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/d58a5918_d7bef9c… : PS3, Line 109: static int str_to_usb_desc(char* in, uint8_t in_sz, uint8_t* out, uint8_t out_sz){ open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/b8435e8e_d61b401… : PS3, Line 109: static int str_to_usb_desc(char* in, uint8_t in_sz, uint8_t* out, uint8_t out_sz){ space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/a1380c7e_f7826fb… : PS3, Line 116: for (int i= 2; i < out_sz; i+=2) spaces required around that '=' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/55b6bfb3_87b98e2… : PS3, Line 116: for (int i= 2; i < out_sz; i+=2) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8c17b198_f18a6a5… : PS3, Line 137: while (!hri_nvmctrl_get_STATUS_READY_bit(NVMCTRL)) {} braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/da431cf6_3fe2f2b… : PS3, Line 138: if (hri_nvmctrl_read_STATUS_BOOTPROT_bf(FLASH_0.dev.hw) != 13) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21270): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/a30606b5_7253201… : PS3, Line 139: _user_area_write_bits((void*)NVMCTRL_FUSES_BOOTPROT_ADDR, NVMCTRL_FUSES_BOOTPROT_Pos, 13, 4); "(foo*)" should be "(foo *)" -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I1403d35497cdea41ea5bed2c94b9e729ca352772 Gerrit-Change-Number: 39434 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Comment-Date: Wed, 29 Jan 2025 18:39:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No