msuraev has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29762 ) Change subject: smpp_mirror: fix compiler warning ...................................................................... smpp_mirror: fix compiler warning Use same system_id/password length limits as OsmoMSC. Related: OS#5568 Change-Id: Iaf2b99b80f81762f5b2577f7bc490791c9cc1810 --- M src/utils/smpp_mirror.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/utils/smpp_mirror.c b/src/utils/smpp_mirror.c index 48b9ea2..552ceee 100644 --- a/src/utils/smpp_mirror.c +++ b/src/utils/smpp_mirror.c @@ -117,8 +117,8 @@ memset(&bind, 0, sizeof(bind)); bind.command_id = BIND_TRANSCEIVER; bind.sequence_number = esme_inc_seq_nr(esme); - snprintf((char *)bind.system_id, sizeof(bind.system_id), "%s", esme->system_id); - snprintf((char *)bind.password, sizeof(bind.password), "%s", esme->password); + snprintf((char *)bind.system_id, SMPP_SYS_ID_LEN + 1, "%s", esme->system_id); + snprintf((char *)bind.password, SMPP_SYS_ID_LEN + 1, "%s", esme->password); snprintf((char *)bind.system_type, sizeof(bind.system_type), "mirror"); bind.interface_version = esme->smpp_version; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaf2b99b80f81762f5b2577f7bc490791c9cc1810 Gerrit-Change-Number: 29762 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged