Jenkins Builder has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email ) Change subject: gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2 ...................................................................... Patch Set 1: (14 comments) File src/gsm_rlcmac.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20640): https://gerrit.osmocom.org/c/osmo-pcu/+/39188/comment/d4d6b190_d7dea70b?usp… : PS1, Line 1253: M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_GMSK_MEAN_BEP, 2), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20640): https://gerrit.osmocom.org/c/osmo-pcu/+/39188/comment/6b467de2_b7b0607e?usp… : PS1, Line 1253: M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_GMSK_MEAN_BEP, 2), space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20640): https://gerrit.osmocom.org/c/osmo-pcu/+/39188/comment/1150fe38_23b1557c?usp… : PS1, Line 1257: M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_8PSK_MEAN_BEP, 2), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20640): https://gerrit.osmocom.org/c/osmo-pcu/+/39188/comment/b375e5ef_d3d2a573?usp… : PS1, Line 1257: M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_8PSK_MEAN_BEP, 2), space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20640): https://gerrit.osmocom.org/c/osmo-pcu/+/39188/comment/174c45bd_b62a52f3?usp… : PS1, Line 1261: M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_QPSK_MEAN_BEP, 2), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20640): https://gerrit.osmocom.org/c/osmo-pcu/+/39188/comment/5b1bb6c5_2b87606b?usp… : PS1, Line 1261: M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_QPSK_MEAN_BEP, 2), space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20640): https://gerrit.osmocom.org/c/osmo-pcu/+/39188/comment/213625c4_6a8bcc2b?usp… : PS1, Line 1265: M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_16QAM_NSR_MEAN_BEP, 2), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20640): https://gerrit.osmocom.org/c/osmo-pcu/+/39188/comment/b428eadf_bb911e03?usp… : PS1, Line 1265: M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_16QAM_NSR_MEAN_BEP, 2), space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20640): https://gerrit.osmocom.org/c/osmo-pcu/+/39188/comment/2df8e38f_02e525fb?usp… : PS1, Line 1269: M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_32QAM_NSR_MEAN_BEP, 2), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20640): https://gerrit.osmocom.org/c/osmo-pcu/+/39188/comment/564e74b4_29b44304?usp… : PS1, Line 1269: M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_32QAM_NSR_MEAN_BEP, 2), space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20640): https://gerrit.osmocom.org/c/osmo-pcu/+/39188/comment/53d265e0_a5a2f542?usp… : PS1, Line 1273: M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_16QAM_HSR_MEAN_BEP, 2), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20640): https://gerrit.osmocom.org/c/osmo-pcu/+/39188/comment/08b848a6_ce5c096c?usp… : PS1, Line 1273: M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_16QAM_HSR_MEAN_BEP, 2), space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20640): https://gerrit.osmocom.org/c/osmo-pcu/+/39188/comment/7e6e41ec_b2ce6a29?usp… : PS1, Line 1277: M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_32QAM_HSR_MEAN_BEP, 2), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20640): https://gerrit.osmocom.org/c/osmo-pcu/+/39188/comment/a71b5dd5_04d570ec?usp… : PS1, Line 1277: M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_32QAM_HSR_MEAN_BEP, 2), space prohibited between function name and open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I061ac16df5e6413266de08884f791f0264791192 Gerrit-Change-Number: 39188 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 20 Dec 2024 10:37:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No