Attention is currently required from: neels, pespin, fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 4: (14 comments) Patchset: PS4: I hope I've addressed all your comments. I'll revisited all your comments tomorrow again to ensure I'ven't missed something. File include/osmocom/bsc/bts_setup_ramp.h: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/8a675608_bbf435fb PS3, Line 31: BTS_SETUP_RAMP_INIT, /** initial state */ Thank you! File include/osmocom/bsc/nm_bts_ramp.h: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/56dc7feb_49f0ff6a PS1, Line 40: /*! Thank you for the explanation. File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/d011f286_c5c9da30 PS1, Line 1284: "allow-bts-configuration <0-65535>", Done https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/de0aeb4d_77c496a8 PS1, Line 2659: vty_out(vty, " bts ramp limit %d within %d seconds%s", Done https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/00d3fe9e_888f6435 PS1, Line 3087: "bts ramp limit <0-999> within <0-999> seconds", Done File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/7dcd39db_17a2c54a PS3, Line 3091: "Number of BTS" Done File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/a0b26dd7_d6b938e2 PS3, Line 42: /* inform all MOs */ Done https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/cc1d31d5_70734628 PS3, Line 62: * \brief Unblock a BTS from BTS setup ramping to allow it to setup and configure. Done https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/3d28daaf_728e2118 PS3, Line 77: * \brief Timer callback and called by bts_setup_ramp_deactivate Done https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/55349534_d146c047 PS3, Line 201: llist_del(&bts->bts_setup_ramp.list); It's empty afterwards. File src/osmo-bsc/nm_bb_transc_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/5334a6c9_a3034a82 PS1, Line 345: case NM_EV_RAMP_GO: I've implemented it together with a libosmocore (ignore_invalid_event_mask). Without the libosmocore patch I don't really see the point because it would require to add NM_EV_RAMP_GO in every fsm or it would need to check the state of the fsm before dispatching the signal. File src/osmo-bsc/nm_bts_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/c547ca0b_15126586 PS1, Line 92: struct gsm_bts *bts, IMHO this is fine. last example of 6.2) looks the same. https://www.kernel.org/doc/html/latest/process/coding-style.html File src/osmo-bsc/nm_bts_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/f3dd7853_f0068953 PS1, Line 42: /* inform all MOs */ Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus &lt;lynxis(a)fe80.eu&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-CC: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Comment-Date: Fri, 28 Oct 2022 02:15:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels &lt;nhofmeyr(a)sysmocom.de&gt; Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Comment-In-Reply-To: lynxis lazus &lt;lynxis(a)fe80.eu&gt; Gerrit-MessageType: comment