Attention is currently required from: jolly, neels.

fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38305?usp=email )

Change subject: Create transaction for all call indepenant SS messages ......................................................................

Patch Set 1:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-msc/+/38305/comment/4020c417_9d288750?usp=... : PS1, Line 14: This patch ensures that a transaction is created even if the message : is not a REGISTER message I am fine with this approach in general, however it does not solve the problem globally. We have another early return code path when `trans_alloc()` returns `NULL`, for instance, and the connection would be kept alive for 5 seconds in that case.

I know it's unlikely that `trans_alloc()` (actually the internal `malloc()` call) returns `NULL` on modern Linux systems, but it's just to illustrate that you're fixing only a very specific scenario here.

IMO, a more generic approach would be to call `msc_a_release_cn()` as was suggested by Neels in https://osmocom.org/issues/6426#note-5.