Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28212 )
Change subject: BSC_Tests: add support for per-TRX RSL connections ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File bsc/BSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28212/comment/755be15d_766d4... PS1, Line 963: var integer local_port := 10000 + idx.bts * NUM_TRX + idx.trx; Maybe using idx.bts*1000 would be clearer when looking at pcaps.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28212/comment/2c6c686a_62949... PS1, Line 1372: f_ipa_tx(ts_RSL_CHAN_RQD(ra, fn)); You are removing the idx here masking that 0,0 is passed. Maybe declare {0,0} once atr the start and pass it everywhere, so that it's later easier to spot 0,0 is passed and be able to parametrize it.