Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32222 )
Change subject: Introduce NM FSM for GPRS Cell object ......................................................................
Patch Set 3:
(2 comments)
File src/common/bts.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32222/comment/abc6d59c_0671b97d PS3, Line 460: osmo_fsm_inst_dispatch(bts->gprs.nse.mo.fi, NM_EV_SW_ACT, NULL);
not sure, but don't you need to add here: […]
No, only what are considered "top level" FSM objects are done here (the bts_site_mgr and bts are quite entangled right now, I plan to fix that next). NSE FSM will ev_dispatch_child() to the GPRS CELL.
File src/common/nm_gprs_cell_fsm.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32222/comment/63161639_073d8253 PS3, Line 47: nse
cell?
No, that's intended, we are waiting for the NSE to be enabled here before being able to opstart the GPRS CELL.
-
pespin