Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28105 ) Change subject: ggsn: Append IMEISV IE to CreatePdpCtxReq ...................................................................... Patch Set 1: (2 comments) File ggsn_tests/GGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28105/comment/8d174739_b965… PS1, Line 338: return int2oct(f_rnd_int(18446744073709551616), 8); There is a more elegant way to do this (see Osmocom_Types.f_rnd_imsi()): return hex2oct(f_rnd_hexstring(16, 10)); File library/GTP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28105/comment/0a914183_227b… PS1, Line 129: Usually no tab here, so function body is visually separated from its declaration. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I00975328e94afd116e59c88fd96c5b0154810a1e Gerrit-Change-Number: 28105 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 May 2022 15:23:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment