jtavares has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30139 )

Change subject: bankd: Add GSMTAP functionality for SIM traffic ......................................................................

Patch Set 2:

(3 comments)

Patchset:

PS2: I believe Jenkins issues have been fixed with Patchset #2

File src/bankd/bankd.h:

https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/33c0685b_ff78f35b PS1, Line 136: char* gsmtap_host;

"foo* bar" should be "foo *bar"

Please fix.

File src/bankd/gsmtap.h:

https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/7643990a_2a6340ca PS1, Line 7: const uint8_t *sim_tpdu, unsigned int sim_tpdu_len);

adding a line without newline at end of file

Please fix.