jtavares has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30139 ) Change subject: bankd: Add GSMTAP functionality for SIM traffic ...................................................................... Patch Set 2: (3 comments) Patchset: PS2: I believe Jenkins issues have been fixed with Patchset #2 File src/bankd/bankd.h: https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/33c0685b_ff78f35b PS1, Line 136: char* gsmtap_host; Please fix. File src/bankd/gsmtap.h: https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/7643990a_2a6340ca PS1, Line 7: const uint8_t *sim_tpdu, unsigned int sim_tpdu_len); Please fix. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I05b599858d8758633aa56c3f12f258c27cf42d08 Gerrit-Change-Number: 30139 Gerrit-PatchSet: 2 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 14 Nov 2022 14:49:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment