Attention is currently required from: laforge, daniel, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31069 ) Change subject: gprs_ns2_fr: use osmo_netdev to montior and operate network device ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Tested here (I will remove the jenkins job I created temporarily to test the patch once it has been reviewed and merged): https://jenkins.osmocom.org/jenkins/job/ttcn3-gbproxy-test-fr-pespin/3/cons… Sample osmo-gbproxy file showing it is being used during the tests: """ 20230125164551103 DLGLOBAL <0002> netdev.c:442 netdev_netns_ctx_mnl_cb(): index=4 type=770 flags=0x100d1 family=0 20230125164551103 DLGLOBAL <0002> netdev.c:391 NETDEV(hdlcnet1,if=hdlcnet1/4,ns=): netdev_mnl_cb(): ifname=hdlcnet1 20230125164551103 DLGLOBAL <0002> netdev.c:411 NETDEV(hdlcnet1,if=hdlcnet1/4,ns=): netdev_mnl_cb(): mtu=1700 20230125164551103 DLGLOBAL <0002> netdev.c:361 NETDEV(hdlcnet1,if=hdlcnet1/4,ns=): MTU changed: 1700 20230125164551103 DLNS <0015> gprs_ns2_fr.c:562 BIND(hdlcnet1) MTU changed from 1600 to 1700. 20230125164551103 DLGLOBAL <0002> netdev.c:422 NETDEV(hdlcnet1,if=hdlcnet1/4,ns=): netdev_mnl_cb(): up=1 running=1 20230125164551103 DLGLOBAL <0002> netdev.c:374 NETDEV(hdlcnet1,if=hdlcnet1/4,ns=): Physical link state changed: UP 20230125164551103 DLNS <0015> gprs_ns2_fr.c:526 BIND(hdlcnet1) FR net-device 'hdlcnet1': Physical link state changed: UP 20230125164551103 DLGLOBAL <0002> netdev.c:442 netdev_netns_ctx_mnl_cb(): index=6 type=770 flags=0x100d1 family=0 20230125164551103 DLGLOBAL <0002> netdev.c:391 NETDEV(hdlcnet2,if=hdlcnet2/6,ns=): netdev_mnl_cb(): ifname=hdlcnet2 20230125164551103 DLGLOBAL <0002> netdev.c:411 NETDEV(hdlcnet2,if=hdlcnet2/6,ns=): netdev_mnl_cb(): mtu=1700 20230125164551103 DLGLOBAL <0002> netdev.c:361 NETDEV(hdlcnet2,if=hdlcnet2/6,ns=): MTU changed: 1700 20230125164551103 DLNS <0015> gprs_ns2_fr.c:562 BIND(hdlcnet2) MTU changed from 1600 to 1700. 20230125164551103 DLGLOBAL <0002> netdev.c:422 NETDEV(hdlcnet2,if=hdlcnet2/6,ns=): netdev_mnl_cb(): up=1 running=1 20230125164551103 DLGLOBAL <0002> netdev.c:374 NETDEV(hdlcnet2,if=hdlcnet2/6,ns=): Physical link state changed: UP 20230125164551103 DLNS <0015> gprs_ns2_fr.c:526 BIND(hdlcnet2) FR net-device 'hdlcnet2': Physical link state changed: UP 20230125164551103 DLGLOBAL <0002> netdev.c:442 netdev_netns_ctx_mnl_cb(): index=8 type=770 flags=0x100d1 family=0 20230125164551104 DLGLOBAL <0002> netdev.c:391 NETDEV(hdlcnet3,if=hdlcnet3/8,ns=): netdev_mnl_cb(): ifname=hdlcnet3 20230125164551104 DLGLOBAL <0002> netdev.c:411 NETDEV(hdlcnet3,if=hdlcnet3/8,ns=): netdev_mnl_cb(): mtu=1700 20230125164551104 DLGLOBAL <0002> netdev.c:361 NETDEV(hdlcnet3,if=hdlcnet3/8,ns=): MTU changed: 1700 20230125164551104 DLNS <0015> gprs_ns2_fr.c:562 BIND(hdlcnet3) MTU changed from 1600 to 1700. 20230125164551104 DLGLOBAL <0002> netdev.c:422 NETDEV(hdlcnet3,if=hdlcnet3/8,ns=): netdev_mnl_cb(): up=1 running=1 20230125164551104 DLGLOBAL <0002> netdev.c:374 NETDEV(hdlcnet3,if=hdlcnet3/8,ns=): Physical link state changed: UP 20230125164551104 DLNS <0015> gprs_ns2_fr.c:526 BIND(hdlcnet3) FR net-device 'hdlcnet3': Physical link state changed: UP 20230125164551104 DLGLOBAL <0002> netdev.c:442 netdev_netns_ctx_mnl_cb(): index=10 type=770 flags=0x100d1 family=0 20230125164551104 DLGLOBAL <0002> netdev.c:391 NETDEV(hdlcnet4,if=hdlcnet4/10,ns=): netdev_mnl_cb(): ifname=hdlcnet4 20230125164551104 DLGLOBAL <0002> netdev.c:411 NETDEV(hdlcnet4,if=hdlcnet4/10,ns=): netdev_mnl_cb(): mtu=1700 20230125164551104 DLGLOBAL <0002> netdev.c:361 NETDEV(hdlcnet4,if=hdlcnet4/10,ns=): MTU changed: 1700 20230125164551104 DLNS <0015> gprs_ns2_fr.c:562 BIND(hdlcnet4) MTU changed from 1600 to 1700. 20230125164551104 DLGLOBAL <0002> netdev.c:422 NETDEV(hdlcnet4,if=hdlcnet4/10,ns=): netdev_mnl_cb(): up=1 running=1 20230125164551104 DLGLOBAL <0002> netdev.c:374 NETDEV(hdlcnet4,if=hdlcnet4/10,ns=): Physical link state changed: UP 20230125164551104 DLNS <0015> gprs_ns2_fr.c:526 BIND(hdlcnet4) FR net-device 'hdlcnet4': Physical link state changed: UP 20230125164551104 DLGLOBAL <0002> netdev.c:442 netdev_netns_ctx_mnl_cb(): index=12 type=770 flags=0x100d1 family=0 20230125164551104 DLGLOBAL <0002> netdev.c:391 NETDEV(hdlcnet5,if=hdlcnet5/12,ns=): netdev_mnl_cb(): ifname=hdlcnet5 20230125164551104 DLGLOBAL <0002> netdev.c:411 NETDEV(hdlcnet5,if=hdlcnet5/12,ns=): netdev_mnl_cb(): mtu=1700 20230125164551104 DLGLOBAL <0002> netdev.c:361 NETDEV(hdlcnet5,if=hdlcnet5/12,ns=): MTU changed: 1700 20230125164551104 DLNS <0015> gprs_ns2_fr.c:562 BIND(hdlcnet5) MTU changed from 1600 to 1700. 20230125164551104 DLGLOBAL <0002> netdev.c:422 NETDEV(hdlcnet5,if=hdlcnet5/12,ns=): netdev_mnl_cb(): up=1 running=1 20230125164551104 DLGLOBAL <0002> netdev.c:374 NETDEV(hdlcnet5,if=hdlcnet5/12,ns=): Physical link state changed: UP 20230125164551104 DLNS <0015> gprs_ns2_fr.c:526 BIND(hdlcnet5) FR net-device 'hdlcnet5': Physical link state changed: UP 20230125164551104 DLGLOBAL <0002> netdev.c:442 netdev_netns_ctx_mnl_cb(): index=14 type=770 flags=0x100d1 family=0 20230125164551104 DLGLOBAL <0002> netdev.c:391 NETDEV(hdlcnet6,if=hdlcnet6/14,ns=): netdev_mnl_cb(): ifname=hdlcnet6 20230125164551104 DLGLOBAL <0002> netdev.c:411 NETDEV(hdlcnet6,if=hdlcnet6/14,ns=): netdev_mnl_cb(): mtu=1700 20230125164551104 DLGLOBAL <0002> netdev.c:361 NETDEV(hdlcnet6,if=hdlcnet6/14,ns=): MTU changed: 1700 20230125164551104 DLNS <0015> gprs_ns2_fr.c:562 BIND(hdlcnet6) MTU changed from 1600 to 1700. 20230125164551104 DLGLOBAL <0002> netdev.c:422 NETDEV(hdlcnet6,if=hdlcnet6/14,ns=): netdev_mnl_cb(): up=1 running=1 20230125164551104 DLGLOBAL <0002> netdev.c:374 NETDEV(hdlcnet6,if=hdlcnet6/14,ns=): Physical link state changed: UP 20230125164551104 DLNS <0015> gprs_ns2_fr.c:526 BIND(hdlcnet6) FR net-device 'hdlcnet6': Physical link state changed: UP 20230125164551104 DLGLOBAL <0002> netdev.c:442 netdev_netns_ctx_mnl_cb(): index=16 type=770 flags=0x100d1 family=0 20230125164551104 DLGLOBAL <0002> netdev.c:391 NETDEV(hdlcnet7,if=hdlcnet7/16,ns=): netdev_mnl_cb(): ifname=hdlcnet7 20230125164551104 DLGLOBAL <0002> netdev.c:411 NETDEV(hdlcnet7,if=hdlcnet7/16,ns=): netdev_mnl_cb(): mtu=1700 20230125164551104 DLGLOBAL <0002> netdev.c:361 NETDEV(hdlcnet7,if=hdlcnet7/16,ns=): MTU changed: 1700 20230125164551105 DLNS <0015> gprs_ns2_fr.c:562 BIND(hdlcnet7) MTU changed from 1600 to 1700. 20230125164551105 DLGLOBAL <0002> netdev.c:422 NETDEV(hdlcnet7,if=hdlcnet7/16,ns=): netdev_mnl_cb(): up=1 running=1 20230125164551105 DLGLOBAL <0002> netdev.c:374 NETDEV(hdlcnet7,if=hdlcnet7/16,ns=): Physical link state changed: UP 20230125164551105 DLNS <0015> gprs_ns2_fr.c:526 BIND(hdlcnet7) FR net-device 'hdlcnet7': Physical link state changed: UP 20230125164551105 DLGLOBAL <0002> netdev.c:442 netdev_netns_ctx_mnl_cb(): index=18 type=770 flags=0x100d1 family=0 20230125164551105 DLGLOBAL <0002> netdev.c:391 NETDEV(hdlcnet8,if=hdlcnet8/18,ns=): netdev_mnl_cb(): ifname=hdlcnet8 20230125164551105 DLGLOBAL <0002> netdev.c:411 NETDEV(hdlcnet8,if=hdlcnet8/18,ns=): netdev_mnl_cb(): mtu=1700 20230125164551105 DLGLOBAL <0002> netdev.c:361 NETDEV(hdlcnet8,if=hdlcnet8/18,ns=): MTU changed: 1700 20230125164551105 DLNS <0015> gprs_ns2_fr.c:562 BIND(hdlcnet8) MTU changed from 1600 to 1700. 20230125164551105 DLGLOBAL <0002> netdev.c:422 NETDEV(hdlcnet8,if=hdlcnet8/18,ns=): netdev_mnl_cb(): up=1 running=1 20230125164551105 DLGLOBAL <0002> netdev.c:374 NETDEV(hdlcnet8,if=hdlcnet8/18,ns=): Physical link state changed: UP 20230125164551105 DLNS <0015> gprs_ns2_fr.c:526 BIND(hdlcnet8) FR net-device 'hdlcnet8': Physical link state changed: UP """ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib0e499e09c50135a5c4a361332d6120f660a1a45 Gerrit-Change-Number: 31069 Gerrit-PatchSet: 4 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Reviewer: lynxis lazus &lt;lynxis(a)fe80.eu&gt; Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Attention: lynxis lazus &lt;lynxis(a)fe80.eu&gt; Gerrit-Comment-Date: Wed, 25 Jan 2023 16:57:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment