Attention is currently required from: osmith, jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32786 ) Change subject: Migrate network identifier fields to modern osmocom structures ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/host/layer23/include/osmocom/bb/common/networks.h: https://gerrit.osmocom.org/c/osmocom-bb/+/32786/comment/b981f9dd_6b1ed90d PS3, Line 23: uint16_t gsm_mcc_to_hex(uint16_t mcc); shouldn't those generic mcc/mnc to hex functions be in libosmogsm? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I07a9289825c09ed748e53d36a746ea164c8a5d7f Gerrit-Change-Number: 32786 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 May 2023 09:57:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment