Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email ) Change subject: enft_kpi: retrieve per-eNB traffic counters ...................................................................... Patch Set 8: (2 comments) File config/sys.config: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/a81661e6_4544… : PS8, Line 24: %% {enft_kpi_enable, true}, %% whether to enable the NFT KPI module (default: false) "nft" is a well known and established system-wide component, which users can easily understand from general knowledge. Since the code is operating on a system-wide component shared with other stuff running in the system, I consider this to be important enough to be something to tell the user, specially since one of the params is totally directly related to the fact that "nft" is used ("nft_kpi_table_name"). gtpu_kpi would also be definetly better than "enft", because again GTPU is some well known component which means user doesn't need to figure out what "enft" means in this particular context. If for you proepr naming of configuration parameters which is to be read and set by users is a "trivial detail" and equals the color of a bikeshed, then so be it an I have nothing more to say. If you think joining the all-is-bikeshed trend is really helping here, also I have nothing more to say. In any case, I already provided a +1 beforehand, do as you please, my argument have been given. File rebar.config: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/7739e93a_7d7c… : PS8, Line 13: {git, "https://gitea.osmocom.org/vyanitskiy/enftables.git", {branch, "fixeria/json"}}}, That's exactly what I meant, sorry if it was not clear, fine with it. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I498d2854447a2d53d2abddd38652f3e2bbb1fbdd Gerrit-Change-Number: 40281 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 May 2025 13:46:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>