Attention is currently required from: laforge, pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476 )
Change subject: Support forwarding messages with multiple BSCs
......................................................................
Patch Set 4:
(5 comments)
File include/osmocom/bsc_nat/bsc_nat.h:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476/comment/bad2efd8_54ecce7a
PS2, Line 26: BSC_NAT_CN = 0,
you probably lack a prefix there for the enum. BSC_NAT
is the domain, and CN and RAN the elements. […]
Done, in earlier commit
"bsc_nat_print_addr: pass net enum, not sccp_inst"
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476/comment/ccec5d29_5f8df4a1
PS2, Line 48: uint32_t subscr_conn_id_next[2]; /* for CN, RAN */
one could even go one further and have sub-structs
like […]
Done
File include/osmocom/bsc_nat/subscr_conn.h:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476/comment/fcf897ba_15728c37
PS2, Line 29: uint32_t id[2]; /* conn_id for CN, RAN */
same, there's problably no good reason to have
this as an array. […]
Done
File src/osmo-bsc-nat/bsc.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476/comment/6a5a2423_adda9852
PS2, Line 58: subscr_conn_free_by_bsc(bsc);
This looks weird. I'd expect a subscr being passed
here seeing the name of the function. […]
Done
File src/osmo-bsc-nat/msc.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476/comment/1a136e56_4eea3e44
PS2, Line 77: subscr_conn_free_by_msc(msc);
same: msc_free_subscr_conn_all()
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: I1556aa665fbb0a97507f98794e74820731fa6935
Gerrit-Change-Number: 27476
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Mar 2022 15:38:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment