Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30993 ) Change subject: layer23: Introduce netdev.{c,h} ...................................................................... Patch Set 1: (42 comments) File src/host/layer23/include/osmocom/bb/common/netdev.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/974517a6_8300ba90 PS1, Line 33: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/862ed064_5a7bb7ea PS1, Line 33: { open brace '{' following struct go on the same line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/d3635462_e150e713 PS1, Line 35: unsigned int ihl:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/07123035_c6fc11e6 PS1, Line 36: unsigned int version:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/2ee76edd_7fe51d29 PS1, Line 38: unsigned int version:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/b4d5f3af_6d2987f1 PS1, Line 39: unsigned int ihl:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/8f3d598b_c49c063f PS1, Line 43: u_int8_t tos; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/e0370cbf_e5be4b4e PS1, Line 44: u_int16_t tot_len; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/2879cc1e_253b27c8 PS1, Line 45: u_int16_t id; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/8a33419a_7620d740 PS1, Line 46: u_int16_t frag_off; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/a261ee75_2d21f3fe PS1, Line 47: u_int8_t ttl; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/fd3b6416_346f89b1 PS1, Line 48: u_int8_t protocol; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/5f20b8aa_31b03089 PS1, Line 49: u_int16_t check; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/eb7c7142_66d994fc PS1, Line 50: u_int32_t saddr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/213488b3_0c7ddef8 PS1, Line 51: u_int32_t daddr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/27c8868e_cdb3b0c1 PS1, Line 53: }; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/66b26939_30349ae5 PS1, Line 57: struct osmo_sockaddr addr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/1ffb9b1c_59356dee PS1, Line 58: uint8_t prefixlen; please, no spaces at the start of a line File src/host/layer23/src/common/netdev.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/abe916c4_f240c420 PS1, Line 45: #elif defined (__FreeBSD__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/7ae62d29_d0fdc71f PS1, Line 49: #elif defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/44c0019a_7ed66740 PS1, Line 61: #define SYS_ERR(sub, pri, en, fmt, args...) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/1d716176_39f66a52 PS1, Line 97: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/30644889_9a1ef400 PS1, Line 125: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/2b1e0fd6_834f8a79 PS1, Line 132: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/438fd2fb_3e2839d8 PS1, Line 160: if (ioctl(fd, SIOCSIFDSTADDR, (caddr_t) & ifr) < 0) { space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/e1b8e3e6_8fabe5f8 PS1, Line 172: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/b570f46b_8c9343cb PS1, Line 191: #if defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/9657513d_22154e20 PS1, Line 213: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/c173a823_2060117d PS1, Line 214: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/951070a9_6b401c54 PS1, Line 249: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/e3387aca_bea5ef0d PS1, Line 381: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/213b2629_9f00a34e PS1, Line 381: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/42091dc8_550c1a45 PS1, Line 387: strncpy(areq.ifra_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/fc48a53c_30fb4c69 PS1, Line 530: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/8df8f585_5fdfd75d PS1, Line 530: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/7a518840_f9fea8ea PS1, Line 536: strncpy(areq.ifra_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/a5e480f8_6fcb843e PS1, Line 608: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/af6075a7_b44207bd PS1, Line 677: strncpy(ifr.ifr_name, gw_iface, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/15cc4700_1eb2dc9b PS1, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/5aba5335_ac30d4d3 PS1, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/3c3454b7_bf17c446 PS1, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2781): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/be5ca955_03c9a664 PS1, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6085dc6861687bd4e9c32e86221c0375ad95ba22 Gerrit-Change-Number: 30993 Gerrit-PatchSet: 1 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 16 Jan 2023 17:23:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment