Attention is currently required from: fixeria, jolly, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email )
Change subject: Implement M3UA-over-TCP (in addition to SCTP) ......................................................................
Patch Set 5: Code-Review+1
(4 comments)
File include/osmocom/sigtran/osmo_ss7.h:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/ddb13431_e8b5dcbb PS4, Line 515: int osmo_ss7_asp_get_trans_proto(const struct osmo_ss7_asp *asp);
It's not specific about this API, but in general when having developed stuff for libosmo-sccp I have […]
I understand where pespin is coming from (and agree I made too much public initially). However, I think in this specific case it is not a problem to add this new function. It does not expose any structure details, it is merely an accessor function returning a value. Let's stop spending time discussing about it.
File include/osmocom/sigtran/osmo_ss7.h:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/6a20520d_c86e2387 PS3, Line 616: osmo_sccp_simple_client2(void *ctx, const char *name, uint32_t default_pc,
My understanding is that for current ticket only osmo-stp is needed. […]
agreeing fully with pespin.
File src/osmo_ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/f5fe9e33_6908a2bf PS1, Line 853: ss7_asp_m3ua_tcp_srv_conn_cb
(re-opening the thread, since this was not addressed yet) […]
yes, all of this is going away once the netif-stream osmo-io SCTP patches is merged. No need to rework it now.
File src/osmo_ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/4fc14395_a23feaea PS4, Line 133: #define PROTO_MUX(proto, trans_proto) \
I still think this should be changed to avoid doing assumptions about size and max value of trans_pr […]
if we do it like it's done here, there should be a static_assert, as I mentioned. If we do it without that shift+mask, no static_assert needed.
-
laforge