Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33611 ) Change subject: ASCI: Add FSM for VGCS/VBS ...................................................................... Patch Set 1: (4 comments) File include/osmocom/bsc/vgcs_fsm.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9028): https://gerrit.osmocom.org/c/osmo-bsc/+/33611/comment/77f7a922_1ba06aaf PS1, Line 59: /* Channel link failed. (Talker faild.) */ 'faild' may be misspelled - perhaps 'failed'? File src/osmo-bsc/vgcs_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9028): https://gerrit.osmocom.org/c/osmo-bsc/+/33611/comment/f09fcbc5_4536984f PS1, Line 373: LOG_CALL(conn, LOGL_DEBUG, "Calling subscriber assiged and now on uplink.\n"); 'assiged' may be misspelled - perhaps 'assigned'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9028): https://gerrit.osmocom.org/c/osmo-bsc/+/33611/comment/acad8bf7_09ebeb63 PS1, Line 668: no_aoip: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9028): https://gerrit.osmocom.org/c/osmo-bsc/+/33611/comment/c29dfe5a_ead854dc PS1, Line 1155: strcpy(conn->vgcs_chan.msc_rtp_addr, req.msc_rtp_addr); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9e94fb4f27bb438b7093c031344a3400bfa34f1 Gerrit-Change-Number: 33611 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Jul 2023 13:28:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment