Attention is currently required from: jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31033 )
Change subject: Add L1 signals to misdn driver ......................................................................
Patch Set 3:
(1 comment)
File src/input/misdn.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/31033/comment/5753cd83_45020aad PS3, Line 115: LOGP(DLMI, LOGL_DEBUG, "L1_SIGNAL_LOS_OFF\n");
did you think about using a value_string to print the type?
I agree, a value_string migt make sense. But then ideally that value_string would be on the generic side, so something like the driver converts to the S_L_INP_*, which gets passed to some generic function. The generic function then prints the log and dispatches the signal.
This way we would have shared code for printing identical log messages irrespective of the driver.
Also, the log levels should probably be adjusted. AIS, LOS and RAI state are highly unusual in normal operation and should be NOTICE, from my point of view.
-
laforge