dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38300?usp=email ) Change subject: cosmetic: use **kwargs instead of **_kwargs ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I think this is more a question of coding convention. In all those files **kwargs is not used. I guess the underscore is inherited from erlang where unused parameters must be prefixed with an underscore, otherwise the compiler would reject the code. In python there is no such limitation and a quick search for **_kwargs also didn't reveal any info if this is a common convention or not. I would suggest to remove the underscore prefix. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38300?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I98857cc774185e55a604eb4fbfbf62ed4bd6ded7 Gerrit-Change-Number: 38300 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 26 Sep 2024 09:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No