Attention is currently required from: dexter.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/34404?usp=email )
Change subject: mgcp_client_fsm: allocate struct mgcp_conn_peer dynamically
......................................................................
Patch Set 9:
(4 comments)
This change is ready for review.
File src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/34404/comment/8fbc184f_38afefd0
PS5, Line 692: osmo_strlcpy(cleared_ci.mgcp_ci_str, ci->mgcp_ci_str,
sizeof(cleared_ci.mgcp_ci_str));
mark
Done
https://gerrit.osmocom.org/c/osmo-mgw/+/34404/comment/8074c879_64a30269
PS5, Line 826: .ep = ep,
mark
Done
https://gerrit.osmocom.org/c/osmo-mgw/+/34404/comment/33b4e5d2_e5b39f31
PS5, Line 1052: *ci = (struct osmo_mgcpc_ep_ci){
mark
Done
File src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/34404/comment/02fbdf1b_c160c06c
PS7, Line 98: struct mgcp_conn_peer *verb_info;
since this struct is used only within this .c file
scope, there is no need to modify this code. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/34404?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I523d0fcb020f7d46323c497a4be9ee00d5f242ba
Gerrit-Change-Number: 34404
Gerrit-PatchSet: 9
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 01 Nov 2023 21:16:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment