Attention is currently required from: neels.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31669 )
Change subject: gsm0502: add burst length definitions from chapter 5.2
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
(I prefer enums instead of preproc constants, because
then you can indicate in function args exactly […]
I see no point using enums for
something that will unlikely end up in a `switch` statement. And this is not like sorts of
the same thing, it's bit length values... I plan to use them as offsets and buffer
sizes.
File include/osmocom/gsm/gsm0502.h:
https://gerrit.osmocom.org/c/libosmocore/+/31669/comment/53908de4_4997e26f
PS1, Line 36: #define GSM_NBITS_NB_GMSK_PAYLOAD 2 * 58
you should have braces around that operation, at least
for preproc constants. […]
You say *should*, but your CR-1 looks more like *must*?
:) Can you explain why is it needed to have braces around multiplication? I would agree if
this was `a + b` or `a - b`, but here I don't see what do we guard against. And no,
see my comment above why not enums.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31669
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1c38ccc2b64ba9046bb3b1221d99cc55ec493802
Gerrit-Change-Number: 31669
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 06 Mar 2023 03:33:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment