Attention is currently required from: osmith, laforge, pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/32786 )
Change subject: Migrate network identifier fields to modern osmocom structures
......................................................................
Patch Set 4:
(5 comments)
File src/host/layer23/src/common/subscriber.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/32786/comment/5f0144a5_383e25e8
PS3, Line 414: %s
Good point, thanks I'll fix it now.
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/32786/comment/49ee3d41_35b182f2
PS3, Line 495: %s
dito
Done
File src/host/layer23/src/mobile/gsm322.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/32786/comment/5046e210_0df937d5
PS3, Line 4806: %s
The table will be distorted when 2 digit MNC is
displayed. […]
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/32786/comment/6790fd88_8e3fd792
PS3, Line 4837: %s
dito
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/32786/comment/6695ec1f_b79bdcfb
PS3, Line 4879: %s
dito
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/32786
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I07a9289825c09ed748e53d36a746ea164c8a5d7f
Gerrit-Change-Number: 32786
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 22 May 2023 14:37:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment