Attention is currently required from: laforge.

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32151 )

Change subject: SCCP N-PCSTATE: trigger MSC status on PC availability ......................................................................

Patch Set 2:

(1 comment)

File src/osmo-bsc/osmo_bsc_sigtran.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/32151/comment/0b010da3_39222232 PS1, Line 112: static struct bsc_msc_data *get_msc_by_pc(uint32_t pc) : { : struct bsc_msc_data *msc; : llist_for_each_entry(msc, msc_list, entry) { : if ((msc->a.msc_addr.presence & OSMO_SCCP_ADDR_T_PC) == 0) : continue; : if (msc->a.msc_addr.pc == pc) : return msc; : } : return NULL; : }

don't we somehow need to involve the sccp_instance in this? AFAICT we can have multiple MSCs within […]

gotcha, of course.