Attention is currently required from: falconia.

pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38323?usp=email )

Change subject: TRAU frame output EDATA: set sync pattern bits ......................................................................

Patch Set 1:

(2 comments)

File src/trau/trau_frame.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/38323/comment/d29628fa_bcb0013d?... : PS1, Line 680: memset(trau_bits, 0, 16); did you check if it makes sense that this function expects the trau_bits to be 0 initialized? Eg existing callers of the function.

https://gerrit.osmocom.org/c/libosmo-abis/+/38323/comment/e82619f0_c39670b2?... : PS1, Line 681: trau_bits[17] = 1; isn't this overwritten by the memcpy below?