Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30116 ) Change subject: [codecs filter] add codec_filter.h,c ...................................................................... Patch Set 1: (1 comment) File src/libmsc/codec_filter.c: https://gerrit.osmocom.org/c/osmo-msc/+/30116/comment/a90de27e_cb9797a4 PS1, Line 124: /* If osmo-msc were able to trigger a re-assignment after the remote side has picked a codec mismatching the yes. When we offer the remote call leg a list of codecs, that remote could freely pick one/several of those. But currently osmo-msc first does an Assignment with one specific codec. So it *could* go like this: 1. local call leg assigns a codec 2. offer a list of possible codecs to other side 3. other side picks a different codec than the assigned one 4. local call leg re-assigns a different codec but currently osmo-msc has no code to do step 4. it wouldn't be that hard to implement, but i want to get the current pipeline of patches through without adding more work now. but, instead, my favorite way to fix this behavior is to postpone assignment to after the remote side has responded with a list of the remote codecs, then we can directly assign a codec that matches both sides. again, something to consider later: 1. offer a list of codecs 2. remote responds with a list of codecs it supports 3. intersect that info and assign a codec matching both call legs either of these ideas would finally implement some sort of intelligence in matching codecs between call legs; so far we're stuck with MO call leg dictating a single codec, and if the MT side doesn't support it the call is impossible (even if a different codec choice would work on both sides) '#if ALLOW_REASSIGNMENT' is more like '#if 0' now -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4d90f7ca62f2307a7b93dd164aeecbf4bd98ff0a Gerrit-Change-Number: 30116 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Nov 2022 22:48:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment