Attention is currently required from: jolly, pespin, fixeria. Hello Jenkins Builder, jolly, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32694 to look at the new patch set (#2). Change subject: gprs_rlcmac: also use direct TLLI PCUIF for paging MAC blocks ...................................................................... gprs_rlcmac: also use direct TLLI PCUIF for paging MAC blocks In the current code we still send PAGING COMMAND MAC blocks via SAPI PCU_IF_SAPI_PCH, which technically belongs to the older PCUIF version (v.10), which we are going to deprecate soon. To give some background information it should be noted that this bug has its root cause in a misconception on how the receiving end should behave when it receives PAGING COMMAND macblocks. It was not clear that PAGING COMMAND and IMMEDIATE ASSIGNMENT (via PCH) require a confirmation by the receiving end. Since osmo-bts uses the old V.10 PCUIF interface we get a confirmation for both message types, but osmo-bsc, which uses the newer V.11 interface will only confirm IMMEDIATE ASSIGNMENT messages, to distinguish between both message types it uses SAPI PCU_IF_SAPI_PCH for PAGING COMMAND and PCU_IF_SAPI_PCH_DT for IMMEDIATE ASSIGNMENT (confirmed). It is not only confusing to use two different SAPIs to access the PCH, but also wrong. In the new PCUIF interface we should only use PCU_IF_SAPI_PCH_DT. A coresponding patch for osmo-bsc is already submitted (see Depends). Depends: osmo-bsc.git I82443f2b402aa2416469c8c50b1c050323ef3b8f Related: OS#5927 Change-Id: I99cfe373fa157cfb32b74c113ad9935347653a71 --- M src/gprs_rlcmac.c M src/pcu_l1_if.cpp M src/pcu_l1_if.h 3 files changed, 42 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/94/32694/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I99cfe373fa157cfb32b74c113ad9935347653a71 Gerrit-Change-Number: 32694 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset