Attention is currently required from: lynxis lazus. neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email ) Change subject: vlr: extend the subscriber invalidate callback with reasons ...................................................................... Patch Set 8: (6 comments) Patchset: PS8: (summing in past +1 by others to give a +2) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/e58370ca_d66f7b25?usp… : PS5, Line 13: b) if the HLR do a Cancel Location Procedure with reason withdraw I think your idea is correct, that we simply drop the subscriber from the VLR cache. Maybe somewhere in the specs (in the VLR state machine graphs?) they say that some other action could be performed to immediately notify the MS, but as i see it that would be just some kind of optimization. If there is an active conn, we should probably close it with a BSSMAP Clear, which I see in the code is done, so that should be fine. Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/d45ddf3e_2436510f?usp… : PS8, Line 15: d) duplicate entries (unsure if this is valid, but keeping the code as is) duplicate entries are very important to prevent. These obscure cases took some deep thinking to fix back in the days. Search for "evil twin" in MSC_Tests.ttcn. If those tests still pass, you should be fine, IIRC File include/osmocom/vlr/vlr.h: https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/739ce548_17b48b1e?usp… : PS8, Line 207: enum vlr_inval_reason { these aren't from a spec, right? If they are, a comment to link to it would be great https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/9cda0e76_0566c5fb?usp… : PS8, Line 260: . : */ (weird comment line break) File src/libmsc/gsm_04_08.c: https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/5b61aa51_7130904c?usp… : PS8, Line 1587: msc_a_release_cn(msc_a); (re my comment above, this is the release i was talking about, so it is already done properly) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie5b687318b106a230fcee52deba86649641004b3 Gerrit-Change-Number: 38488 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 05 Mar 2025 15:36:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>